Skip to content

Commit 971c2a9

Browse files
committed
[devstack] End the sg-core process on unstack
In #22, sg-core was updated to use the run_process devstack function to start the process. The corresponding function to stop the process was not included. This causes issue when running devstack locally. It stacks the first time, but after running unstack.sh, stack.sh fails with the following error: Error: creating container storage: the container name "sg-core" is already in use by xxxxx. You have to remove that container. Removing the container before running stack prevents this error. The stop_process devstack function does this action.
1 parent 8be4008 commit 971c2a9

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

devstack/plugin.sh

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ if is_service_enabled sg-core; then
6161
fi
6262

6363
if [[ "$1" == "unstack" ]]; then
64-
$SG_CORE_CONTAINER_EXECUTABLE stop sg-core
65-
$SG_CORE_CONTAINER_EXECUTABLE rm -f sg-core
64+
stop_process sg-core
6665
fi
6766

6867
if [[ "$1" == "clean" ]]; then

0 commit comments

Comments
 (0)