Skip to content

[golang] bump to golang 1.24#375

Merged
openshift-merge-bot[bot] merged 4 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24
Sep 22, 2025
Merged

[golang] bump to golang 1.24#375
openshift-merge-bot[bot] merged 4 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24

Conversation

@stuggi

@stuggi stuggi commented Aug 20, 2025

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump golang version and custom_image in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31 (if set)

Also bump dependencies for OpenShift 4.18. Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31):

  • controller-runtime: v0.17.6 → v0.19.7
  • Kubernetes core dependencies: v0.29.15 → v0.31.12
    • k8s.io/api: v0.31.12
    • k8s.io/apimachinery: v0.31.12
    • k8s.io/client-go: v0.31.12
    • k8s.io/apiextensions-apiserver: v0.31.12
  • k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
  • controller-gen: v0.14.0 → v0.18.0
  • envtest: 1.29 → 1.31.0, setup-envtest@latest

To test on existing env, or after landed:

  • update golang to 1.24
  • delete current go.work* files
  • init go work files go work init
  • Delete tools in bin/ subdir of the repo

Depends-On: openstack-k8s-operators/install_yamls#1082
Depends-On: openstack-k8s-operators/openstack-operator#1567

Jira: OSPRH-12935

Comment thread pkg/swift/funcs.go

for i := 0; i < length; i++ {
str[i] = sample[rand.Intn(len(sample))]
str[i] = sample[rand.Intn(len(sample))] //nolint:gosec // G404: Non-cryptographic use acceptable for Swift hash generation

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cschwede should we migrate this to "crypto/rand", or is this not important?

@cschwede

Copy link
Copy Markdown
Collaborator

/test swift-operator-build-deploy-kuttl

@stuggi

stuggi commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

/test swift-operator-build-deploy-kuttl

fyi, we first have to land the openstack-op bump CR before the kuttl tests in the service operators will pass.

* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31

Also fixes golangci-lint reported issues for new v2.4.0 version.

Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Co-authored-by: Claude (Anthropic) claude@anthropic.com
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Update controller-runtime, Kubernetes dependencies, and testing tools
to support OpenShift Container Platform 4.18 (Kubernetes 1.31).

Changes:
- controller-runtime: v0.17.6 → v0.19.7
- Kubernetes core dependencies: v0.29.15 → v0.31.12
  * k8s.io/api: v0.31.12
  * k8s.io/apimachinery: v0.31.12
  * k8s.io/client-go: v0.31.12
  * k8s.io/apiextensions-apiserver: v0.31.12
- k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
- controller-gen: v0.14.0 → v0.18.0
- envtest: 1.29 → 1.31, setup-envtest@latest

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@abays

abays commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/swift-operator-build-deploy-kuttl 48ddff9 link true /test swift-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

/test swift-operator-build-deploy-kuttl

@openshift-ci

openshift-ci Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 7d54e7c into openstack-k8s-operators:main Sep 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants