Skip to content

Commit 9be2832

Browse files
authored
Update ansible-lint pinned version (#688)
* Update ansible-lint pinned version Bump ansible-lint to 25.2.0 * Update ansible-lint-ignore with new linting issues ansible-lint 25.2.0 introduces new linting rules that we are not following. Add them to the ignore list. * Pin to ansible 12.0.0
1 parent f83c43d commit 9be2832

3 files changed

Lines changed: 18 additions & 5 deletions

File tree

.ansible-lint-ignore

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,33 +50,46 @@ roles/servicetelemetry/tasks/pre.yml warning[outdated-tag]
5050
roles/servicetelemetry/vars/dummy_user_certs.yml var-naming[no-role-prefix]
5151

5252
# build/stf-run-ci
53+
# This file contains ignores rule violations for ansible-lint
54+
build/stf-run-ci/defaults/main.yml var-naming[no-reserved]
5355
build/stf-run-ci/handlers/main.yml yaml[new-line-at-end-of-file]
5456
build/stf-run-ci/tasks/clone_repos.yml name[template]
5557
build/stf-run-ci/tasks/clone_repos.yml yaml[empty-lines]
58+
build/stf-run-ci/tasks/create_builds.yml jinja[invalid]
5659
build/stf-run-ci/tasks/create_builds.yml name[missing]
5760
build/stf-run-ci/tasks/create_builds.yml no-changed-when
61+
build/stf-run-ci/tasks/create_catalog.yml jinja[invalid]
5862
build/stf-run-ci/tasks/create_index_image.yml ignore-errors
63+
build/stf-run-ci/tasks/create_index_image.yml jinja[invalid]
5964
build/stf-run-ci/tasks/create_index_image.yml jinja[spacing]
6065
build/stf-run-ci/tasks/create_index_image.yml name[missing]
6166
build/stf-run-ci/tasks/create_index_image.yml no-changed-when
6267
build/stf-run-ci/tasks/create_index_image.yml risky-file-permissions
6368
build/stf-run-ci/tasks/create_index_image.yml yaml[truthy]
69+
build/stf-run-ci/tasks/main.yml jinja[invalid]
6470
build/stf-run-ci/tasks/main.yml jinja[spacing]
6571
build/stf-run-ci/tasks/main.yml key-order[task]
6672
build/stf-run-ci/tasks/main.yml name[missing]
6773
build/stf-run-ci/tasks/main.yml no-changed-when
74+
build/stf-run-ci/tasks/main.yml var-naming[no-reserved]
6875
build/stf-run-ci/tasks/main.yml yaml[braces]
6976
build/stf-run-ci/tasks/pre-clean.yml ignore-errors
77+
build/stf-run-ci/tasks/pre-clean.yml jinja[invalid]
7078
build/stf-run-ci/tasks/preflight_checks.yml name[missing]
7179
build/stf-run-ci/tasks/preflight_checks.yml no-changed-when
80+
build/stf-run-ci/tasks/setup_base.yml jinja[invalid]
7281
build/stf-run-ci/tasks/setup_base.yml name[missing]
82+
build/stf-run-ci/tasks/setup_base.yml var-naming[pattern]
83+
build/stf-run-ci/tasks/setup_elasticsearch.yml jinja[invalid]
7384
build/stf-run-ci/tasks/setup_elasticsearch.yml yaml[new-line-at-end-of-file]
85+
build/stf-run-ci/tasks/setup_registry_auth.yml jinja[invalid]
7486
build/stf-run-ci/tasks/setup_registry_auth.yml no-changed-when
75-
build/stf-run-ci/tasks/setup_stf.yml yaml[trailing-spaces]
87+
build/stf-run-ci/tasks/setup_stf.yml jinja[invalid]
7688
build/stf-run-ci/tasks/setup_stf_from_bundles.yml command-instead-of-shell
7789
build/stf-run-ci/tasks/setup_stf_from_bundles.yml no-changed-when
7890
build/stf-run-ci/tasks/setup_stf_local_build.yml command-instead-of-module
7991
build/stf-run-ci/tasks/setup_stf_local_build.yml command-instead-of-shell
92+
build/stf-run-ci/tasks/setup_stf_local_build.yml jinja[invalid]
8093
build/stf-run-ci/tasks/setup_stf_local_build.yml name[missing]
8194
build/stf-run-ci/tasks/setup_stf_local_build.yml no-changed-when
8295
build/stf-run-ci/tests/test.yml syntax-check[specific]

.ansible/.lock

Whitespace-only changes.

.github/workflows/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ jobs:
2020
python-version: '3.12.8'
2121

2222
- name: Install Ansible
23-
run: pip install ansible
23+
run: pip install ansible==12.0.0
2424

2525
- name: Install operator_sdk.util dependency for Ansible role linting
2626
run: ansible-galaxy collection install operator_sdk.util
2727

2828
- name: Install ansible-lint
29-
run: pip install ansible-lint==24.7.0
29+
run: pip install ansible-lint==25.2.0
3030

3131
- name: Lint Ansible roles/servicetelemetry/ directory
3232
run: ansible-lint roles/servicetelemetry
@@ -47,10 +47,10 @@ jobs:
4747
python-version: '3.12.8'
4848

4949
- name: Install Ansible
50-
run: pip install ansible
50+
run: pip install ansible==12.0.0
5151

5252
- name: Install ansible-lint
53-
run: pip install ansible-lint==24.7.0
53+
run: pip install ansible-lint==25.2.0
5454

5555
- name: Lint Ansible build/stf-run-ci directory
5656
run: ansible-lint build/stf-run-ci

0 commit comments

Comments
 (0)