Skip to content

[golang] bump to golang 1.24#740

Merged
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24
Sep 22, 2025
Merged

[golang] bump to golang 1.24#740
openshift-merge-bot[bot] merged 3 commits into
openstack-k8s-operators:mainfrom
stuggi:golang_1.24

Conversation

@stuggi

@stuggi stuggi commented Aug 21, 2025

Copy link
Copy Markdown
Contributor
  • bump in go.mod (base and api)
  • bump go-toolset in Dockerfile
  • bump golang version and custom_image in github jobs ('.github/workflows')
  • Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
  • Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31 (if set)

Also bump dependencies for OpenShift 4.18. Update controller-runtime, Kubernetes dependencies, and testing tools to support OpenShift Container Platform 4.18 (Kubernetes 1.31):

  • controller-runtime: v0.17.6 → v0.19.7
  • Kubernetes core dependencies: v0.29.15 → v0.31.12
    • k8s.io/api: v0.31.12
    • k8s.io/apimachinery: v0.31.12
    • k8s.io/client-go: v0.31.12
    • k8s.io/apiextensions-apiserver: v0.31.12
  • k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
  • controller-gen: v0.14.0 → v0.18.0
  • envtest: 1.29 → 1.31.0, setup-envtest@latest

To test on existing env, or after landed:

  • update golang to 1.24
  • delete current go.work* files
  • init go work files go work init
  • Delete tools in bin/ subdir of the repo

Depends-On: openstack-k8s-operators/install_yamls#1082
Depends-On: openstack-k8s-operators/openstack-operator#1567

Jira: OSPRH-12935

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/21c8625ec9f64abdb1d4690c261305d1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 33s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 03m 10s
telemetry-openstack-meta-content-provider-master FAILURE in 8m 13s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 08m 39s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2cec44074b2c43eb99c4bb137535e769

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 16s
telemetry-openstack-meta-content-provider-master FAILURE in 9m 00s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 26m 45s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/894c5dfcb3464903a14492df42a1aafc

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 51s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 36s
telemetry-openstack-meta-content-provider-master FAILURE in 9m 23s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 26m 43s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

@softwarefactory-project-zuul

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/dba8a40243fa465faeac7fc2e1a0f38b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 19s
telemetry-openstack-meta-content-provider-master FAILURE in 9m 47s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 24m 57s
⚠️ functional-tests-osp18 SKIPPED Skipped due to failed job telemetry-openstack-meta-content-provider-master

* bump in go.mod (base and api)
* bump go-toolset in Dockerfile
* bump in github jobs ('.github/workflows')
* Bump the golangci-lint version in the .pre-commit-config.yaml to v2.4.0
* Bump build_root_image in .ci-operator.yaml to ci-build-root-golang-1.24-sdk-1.31

Also fixes golangci-lint reported issues for new v2.4.0 version.

Jira: OSPRH-12935
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Co-authored-by: Claude (Anthropic) claude@anthropic.com
Update controller-runtime, Kubernetes dependencies, and testing tools
to support OpenShift Container Platform 4.18 (Kubernetes 1.31).

Changes:
- controller-runtime: v0.17.6 → v0.19.7
- Kubernetes core dependencies: v0.29.15 → v0.31.12
  * k8s.io/api: v0.31.12
  * k8s.io/apimachinery: v0.31.12
  * k8s.io/client-go: v0.31.12
  * k8s.io/apiextensions-apiserver: v0.31.12
- k8s.io/utils: v0.0.0-20240711033017 → v0.0.0-20250820121507
- controller-gen: v0.14.0 → v0.18.0
- envtest: 1.29 → 1.31, setup-envtest@latest

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@stuggi stuggi requested review from abays and removed request for frenzyfriday September 22, 2025 16:24
@openshift-ci

openshift-ci Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays

abays commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

@stuggi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/telemetry-operator-build-deploy-kuttl 6dd1a5f link true /test telemetry-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

{  failed to wait for the created cluster claim to become ready: timed out waiting for the condition}

/test telemetry-operator-build-deploy-kuttl

@openshift-merge-bot openshift-merge-bot Bot merged commit 18c08ce into openstack-k8s-operators:main Sep 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants