Merge pull request #346 from kstrenkova/fix-test-operator-typos

Fix typos across test-operator code

Author: openshift-merge-bot[bot]

Makefile

@@ -151,7 +151,7 @@ docker-push: ## Push docker image with the manager.
 # architectures. (i.e. make docker-buildx IMG=myregistry/mypoperator:0.0.1). To use this option you need to:
 # - able to use docker buildx . More info: https://docs.docker.com/build/buildx/
 # - have enable BuildKit, More info: https://docs.docker.com/develop/develop-images/build_enhancements/
-# - be able to push the image for your registry (i.e. if you do not inform a valid value via IMG=<myregistry/image:<tag>> than the export will fail)
+# - be able to push the image for your registry (i.e. if you do not pass a valid value via IMG=<myregistry/image:<tag>> then the export will fail)
 # To properly provided solutions that supports more than one platform you should use this option.
 PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le
 .PHONY: docker-buildx

README.md

@@ -38,7 +38,7 @@ pre-commit install --install-hooks
 2. Execute pre-commit checks
 
 ```bash
-pre-commit run --show-diff-on-failure --color=always --all-files --show-diff-on-failure --verbose
+pre-commit run --show-diff-on-failure --color=always --all-files --verbose
 ```
 
 ### Test It Out

api/bases/test.openstack.org_ansibletests.yaml

@@ -1285,7 +1285,7 @@ spec:
                   capabilities on top of capabilities that are usually needed by the test
                   pods (NET_ADMIN, NET_RAW). This parameter is deemed insecure but it is
                   needed for certain test-operator functionalities to work properly (e.g.:
-                  extraRPMs in Tempest CR, or certain set of tobiko tests).
+                  extraRPMs in Tempest CR, or a certain set of tobiko tests).
                 type: boolean
               resources:
                 default:
@@ -1513,7 +1513,7 @@ spec:
                         pods with allowedPrivilegedEscalation: true and the default capabilities on
                         top of capabilities that are usually needed by the test pods (NET_ADMIN, NET_RAW).
                         This parameter is deemed insecure but it is needed for certain test-operator
-                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or certain set
+                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or a certain set
                         of tobiko tests).
                       type: boolean
                     resources:

api/bases/test.openstack.org_horizontests.yaml

@@ -1303,7 +1303,7 @@ spec:
                   capabilities on top of capabilities that are usually needed by the test
                   pods (NET_ADMIN, NET_RAW). This parameter is deemed insecure but it is
                   needed for certain test-operator functionalities to work properly (e.g.:
-                  extraRPMs in Tempest CR, or certain set of tobiko tests).
+                  extraRPMs in Tempest CR, or a certain set of tobiko tests).
                 type: boolean
               projectName:
                 default: horizontest

api/bases/test.openstack.org_tempests.yaml

@@ -1284,7 +1284,7 @@ spec:
                   capabilities on top of capabilities that are usually needed by the test
                   pods (NET_ADMIN, NET_RAW). This parameter is deemed insecure but it is
                   needed for certain test-operator functionalities to work properly (e.g.:
-                  extraRPMs in Tempest CR, or certain set of tobiko tests).
+                  extraRPMs in Tempest CR, or a certain set of tobiko tests).
                 type: boolean
               rerunFailedTests:
                 default: false
@@ -1375,7 +1375,7 @@ spec:
               tempestRun:
                 description: |-
                   TempestRunSpec - is used to configure execution of tempest. Please refer to
-                  Please refer to https://docs.openstack.org/tempest/latest/ for the further
+                  Please refer to https://docs.openstack.org/tempest/latest/ for further
                   explanation of the CLI parameters.
                 properties:
                   concurrency:
@@ -1554,7 +1554,7 @@ spec:
               tempestconfRun:
                 description: |-
                   TempestconfRunSpec - is used to configure execution of discover-tempest-config
-                  Please refer to https://docs.opendev.org/openinfra/python-tempestconf for the
+                  Please refer to https://docs.opendev.org/openinfra/python-tempestconf for
                   further explanation of the CLI parameters.
                 properties:
                   append:
@@ -1752,7 +1752,7 @@ spec:
                   Workflow - can be used to specify multiple executions of tempest with
                   a different configuration in a single CR. Accepts a list of dictionaries
                   where each member of the list accepts the same values as the Tempest CR
-                  does in the `spec`` section. Values specified using the workflow section have
+                  does in the `spec` section. Values specified using the workflow section have
                   a higher precedence than the values specified higher in the Tempest CR
                   hierarchy.
                 items:
@@ -1854,7 +1854,7 @@ spec:
                         pods with allowedPrivilegedEscalation: true and the default capabilities on
                         top of capabilities that are usually needed by the test pods (NET_ADMIN, NET_RAW).
                         This parameter is deemed insecure but it is needed for certain test-operator
-                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or certain set
+                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or a certain set
                         of tobiko tests).
                       type: boolean
                     rerunFailedTests:
@@ -1941,8 +1941,8 @@ spec:
                       type: string
                     tempestRun:
                       description: |-
-                        TempestRunSpec - is used to configure execution of tempest. Please refer to
-                        Please refer to https://docs.openstack.org/tempest/latest/ for the further
+                        WorkflowTempestRunSpec - is used to configure execution of tempest.
+                        Please refer to https://docs.openstack.org/tempest/latest/ for further
                         explanation of the CLI parameters.
                       properties:
                         concurrency:
@@ -2088,7 +2088,7 @@ spec:
                           type: array
                         extraRPMs:
                           description: |-
-                            A list URLs that point to RPMs that should be downloaded and installed
+                            A list of URLs that point to RPMs that should be downloaded and installed
                             inside the tempest test pod.
                           items:
                             type: string
@@ -2116,8 +2116,8 @@ spec:
                       type: object
                     tempestconfRun:
                       description: |-
-                        TempestconfRunSpec - is used to configure execution of discover-tempest-config
-                        Please refer to https://docs.opendev.org/openinfra/python-tempestconf for the
+                        WorkflowTempestconfRunSpec - is used to configure execution of discover-tempest-config
+                        Please refer to https://docs.opendev.org/openinfra/python-tempestconf for
                         further explanation of the CLI parameters.
                       properties:
                         append:

api/bases/test.openstack.org_tobikoes.yaml

@@ -1289,7 +1289,7 @@ spec:
                   capabilities on top of capabilities that are usually needed by the test
                   pods (NET_ADMIN, NET_RAW). This parameter is deemed insecure but it is
                   needed for certain test-operator functionalities to work properly (e.g.:
-                  extraRPMs in Tempest CR, or certain set of tobiko tests).
+                  extraRPMs in Tempest CR, or a certain set of tobiko tests).
                 type: boolean
               publicKey:
                 default: ""
@@ -1423,7 +1423,7 @@ spec:
                 description: Tobiko version
                 type: string
               workflow:
-                description: A parameter  that contains a workflow definition.
+                description: A parameter that contains a workflow definition.
                 items:
                   properties:
                     SELinuxLevel:
@@ -1496,7 +1496,7 @@ spec:
                       type: object
                     numProcesses:
                       description: Number of processes/workers used to run tobiko
-                        tests - value 0 results in automatic decission
+                        tests - value 0 results in automatic decision
                       type: integer
                     patch:
                       description: Optional patch to apply to the Tobiko repository
@@ -1526,7 +1526,7 @@ spec:
                         pods with allowedPrivilegedEscalation: true and the default capabilities on
                         top of capabilities that are usually needed by the test pods (NET_ADMIN, NET_RAW).
                         This parameter is deemed insecure but it is needed for certain test-operator
-                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or certain set
+                        functionalities to work properly (e.g.: extraRPMs in Tempest CR, or a certain set
                         of tobiko tests).
                       type: boolean
                     publicKey:

api/v1beta1/ansibletest_types.go

@@ -58,7 +58,7 @@ type AnsibleTestSpec struct {
 	// +kubebuilder:validation:Format=string
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// AnsibleGitBranch - git branch to check out in the cloned repo
-	AnsibleGitBranch string `json:"ansibleGitBranch,omitEmpty"`
+	AnsibleGitBranch string `json:"ansibleGitBranch,omitempty"`
 
 	// +kubebuilder:validation:Required
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
@@ -144,7 +144,7 @@ type AnsibleTestWorkflowSpec struct {
 	// +kubebuilder:validation:Format=string
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// AnsibleGitBranch - git branch to check out in the cloned repo
-	AnsibleGitBranch string `json:"ansibleGitBranch,omitEmpty"`
+	AnsibleGitBranch string `json:"ansibleGitBranch,omitempty"`
 
 	// +kubebuilder:validation:Optional
 	// +operator-sdk:csv:customresourcedefinitions:type=spec

api/v1beta1/ansibletest_webhook.go

@@ -91,13 +91,13 @@ func (r *AnsibleTest) ValidateCreate() (admission.Warnings, error) {
 
 		if workflowStep.ExtraConfigmapsMounts != nil {
 			allWarnings = append(allWarnings, "The ExtraConfigmapsMounts parameter will be" +
-				"deprecated! Please use ExtraMounts parameter instead!")
+				" deprecated! Please use ExtraMounts parameter instead!")
 		}
 	}
 
 	if len(r.Spec.ExtraConfigmapsMounts) > 0 {
 		allWarnings = append(allWarnings, "The ExtraConfigmapsMounts parameter will be" +
-			"deprecated! Please use ExtraMounts parameter instead!")
+			" deprecated! Please use ExtraMounts parameter instead!")
 	}
 
 	if r.Spec.Privileged {

api/v1beta1/common.go

@@ -54,7 +54,7 @@ type CommonOptions struct {
 	// capabilities on top of capabilities that are usually needed by the test
 	// pods (NET_ADMIN, NET_RAW). This parameter is deemed insecure but it is
 	// needed for certain test-operator functionalities to work properly (e.g.:
-	// extraRPMs in Tempest CR, or certain set of tobiko tests).
+	// extraRPMs in Tempest CR, or a certain set of tobiko tests).
 	Privileged bool `json:"privileged"`
 
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
@@ -145,7 +145,7 @@ type WorkflowCommonOptions struct {
 	// pods with allowedPrivilegedEscalation: true and the default capabilities on
 	// top of capabilities that are usually needed by the test pods (NET_ADMIN, NET_RAW).
 	// This parameter is deemed insecure but it is needed for certain test-operator
-	// functionalities to work properly (e.g.: extraRPMs in Tempest CR, or certain set
+	// functionalities to work properly (e.g.: extraRPMs in Tempest CR, or a certain set
 	// of tobiko tests).
 	Privileged *bool `json:"privileged,omitempty"`
 

api/v1beta1/common_webhook.go

@@ -2,7 +2,7 @@ package v1beta1
 
 const (
 	// ErrPrivilegedModeRequired
-	ErrPrivilegedModeRequired = "%s.Spec.Privileged is requied in order to successfully " +
+	ErrPrivilegedModeRequired = "%s.Spec.Privileged is required in order to successfully " +
 		"execute tests with the provided configuration."
 
 	// ErrDebug