requeue logic for pending NAD

The operator currently returns a misleading reconcile error when Pod interfaces are not yet ready with assigned IPs.
This change introduces a requeue mechanism to allow time for NetworkAttachmentDefinitions (NAD) to be fully provisioned.

Author: Paulina Osikoya

internal/controller/common.go

@@ -683,13 +683,15 @@ func (r *Reconciler) EnsureNetworkAttachments(
 func (r *Reconciler) VerifyNetworkAttachments(
 	ctx context.Context,
 	helper *helper.Helper,
+	pod *corev1.Pod,
 	instance client.Object,
 	networkAttachments []string,
 	serviceLabels map[string]string,
 	workflowStepIndex int,
 	conditions *condition.Conditions,
 	networkAttachmentStatus *map[string][]string,
 ) (ctrl.Result, error) {
+	Log := r.GetLogger(ctx)
 	if !r.PodExists(ctx, instance, workflowStepIndex) {
 		return ctrl.Result{}, nil
 	}
@@ -713,14 +715,31 @@ func (r *Reconciler) VerifyNetworkAttachments(
 			condition.NetworkAttachmentsReadyMessage)
 	} else {
 		err := fmt.Errorf("%w: %s", ErrNetworkAttachmentsMismatch, networkAttachments)
+
+		// maxWaitTime to wait for NAD that should escalate to a hard error
+		const maxWaitTime = 5 * time.Minute
+		elaspedTime := time.Since(pod.GetCreationTimestamp().Time)
+		if elaspedTime > maxWaitTime {
+			conditions.Set(condition.FalseCondition(
+				condition.NetworkAttachmentsReadyCondition,
+				condition.ErrorReason,
+				condition.SeverityError,
+				condition.NetworkAttachmentsReadyErrorMessage,
+				fmt.Errorf("timed out waiting for network attachments: %w", err).Error()))
+
+			return ctrl.Result{}, err
+		}
+
 		conditions.Set(condition.FalseCondition(
 			condition.NetworkAttachmentsReadyCondition,
-			condition.ErrorReason,
+			"NetworkAttachmentsWaiting",
 			condition.SeverityWarning,
 			condition.NetworkAttachmentsReadyErrorMessage,
 			err.Error()))
 
-		return ctrl.Result{}, err
+		Log.Info("Waiting for network attachments to become  ready", "elasped time", elaspedTime, "max wait time", maxWaitTime)
+
+		return ctrl.Result{RequeueAfter: time.Second * 10}, nil
 	}
 
 	return ctrl.Result{}, nil