Remove deprecated webhook.Defaulter/Validator interface assertions

These compile-time assertions reference webhook.Defaulter and
webhook.Validator interfaces that are removed in controller-runtime
v0.21 (OCP 4.20). The assertions are dead code — webhook registration
already uses CustomDefaulter/CustomValidator in internal/webhook/.

Removing them makes the API module forward-compatible with CR v0.21
so that consumers (like openstack-operator) can bump controller-runtime
without needing replace directives for this operator.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

api/v1beta1/ansibletest_webhook.go

@@ -28,24 +28,19 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
 // log is for logging in this package.
 var ansibletestlog = logf.Log.WithName("ansibletest-resource")
 
-var _ webhook.Defaulter = &AnsibleTest{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *AnsibleTest) Default() {
 	ansibletestlog.Info("default", "name", r.Name)
 
 	// TODO(user): fill in your defaulting logic.
 }
 
-var _ webhook.Validator = &AnsibleTest{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *AnsibleTest) ValidateCreate() (admission.Warnings, error) {
 	ansibletestlog.Info("validate create", "name", r.Name)

api/v1beta1/horizontest_webhook.go

@@ -27,24 +27,19 @@ import (
 
 	"k8s.io/apimachinery/pkg/runtime"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
 // log is for logging in this package.
 var horizontestlog = logf.Log.WithName("horizontest-resource")
 
-var _ webhook.Defaulter = &HorizonTest{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *HorizonTest) Default() {
 	horizontestlog.Info("default", "name", r.Name)
 
 	// TODO(user): fill in your defaulting logic.
 }
 
-var _ webhook.Validator = &HorizonTest{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *HorizonTest) ValidateCreate() (admission.Warnings, error) {
 	horizontestlog.Info("validate create", "name", r.Name)

api/v1beta1/tempest_webhook.go

@@ -29,15 +29,12 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
 // log is for logging in this package.
 var tempestlog = logf.Log.WithName("tempest-resource")
 
-var _ webhook.Defaulter = &Tempest{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *Tempest) Default() {
 	tempestlog.Info("default", "name", r.Name)
@@ -60,8 +57,6 @@ func (r *Tempest) PrivilegedRequired() bool {
 	return len(r.Spec.TempestRun.ExtraImages) > 0
 }
 
-var _ webhook.Validator = &Tempest{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *Tempest) ValidateCreate() (admission.Warnings, error) {
 	tempestlog.Info("validate create", "name", r.Name)

api/v1beta1/tobiko_webhook.go

@@ -29,24 +29,19 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
 // log is for logging in this package.
 var tobikolog = logf.Log.WithName("tobiko-resource")
 
-var _ webhook.Defaulter = &Tobiko{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *Tobiko) Default() {
 	tobikolog.Info("default", "name", r.Name)
 
 	// TODO(user): fill in your defaulting logic.
 }
 
-var _ webhook.Validator = &Tobiko{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *Tobiko) ValidateCreate() (admission.Warnings, error) {
 	tobikolog.Info("validate create", "name", r.Name)