Skip to content

requeue logic for pending NAD#445

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
posikoya:posikoya/refator-reconcile-err
May 28, 2026
Merged

requeue logic for pending NAD#445
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
posikoya:posikoya/refator-reconcile-err

Conversation

@posikoya
Copy link
Copy Markdown
Contributor

@posikoya posikoya commented May 6, 2026

The operator currently returns a misleading reconcile error when Pod interfaces are not yet ready with assigned IPs. This change introduces a requeue mechanism to allow time for NetworkAttachmentDefinitions (NAD) to be fully provisioned.

@openshift-ci openshift-ci Bot requested review from kstrenkova and stuggi May 6, 2026 12:58
@posikoya posikoya marked this pull request as draft May 6, 2026 12:58
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 6, 2026

Hi @posikoya. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 6, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/d991970e3dd54427957f8a896ea9c0bf

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 52s
❌ podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 27m 18s

@posikoya posikoya marked this pull request as ready for review May 11, 2026 08:53
@openshift-ci openshift-ci Bot requested a review from dprince May 11, 2026 08:53
@kstrenkova
Copy link
Copy Markdown
Contributor

kstrenkova commented May 12, 2026

/ok-to-test

kstrenkova
kstrenkova requested changes May 12, 2026
View reviewed changes
Comment thread internal/controller/common.go
Comment thread internal/controller/common.go Outdated
@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch 2 times, most recently from a54229f to 570158d Compare May 28, 2026 04:35
@posikoya posikoya requested a review from kstrenkova May 28, 2026 04:49
@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch from 570158d to adabce3 Compare May 28, 2026 07:56
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 28, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/8cf7158691c147c6b05703b1284c9949

❌ openstack-k8s-operators-content-provider FAILURE in 9m 24s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch 2 times, most recently from c9a6f7d to 2af4f4f Compare May 28, 2026 08:51
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 28, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4f9ac662d3bd4e6c9a60e3fc7d2e54d5

❌ openstack-k8s-operators-content-provider FAILURE in 8m 01s
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch from 2af4f4f to d89fe42 Compare May 28, 2026 12:23
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 28, 2026

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/test-operator for 445,d89fe42ed8df51cb4a0e122135cfc388fe4b19be

@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch 2 times, most recently from ebc9e83 to e765ab1 Compare May 28, 2026 12:40
@posikoya
requeue logic for pending NAD
74c4f92 
The operator currently returns a misleading reconcile error when Pod interfaces are not yet ready with assigned IPs.
This change introduces a requeue mechanism to allow time for NetworkAttachmentDefinitions (NAD) to be fully provisioned.
@posikoya posikoya force-pushed the posikoya/refator-reconcile-err branch from e765ab1 to 74c4f92 Compare May 28, 2026 12:46
kstrenkova
kstrenkova approved these changes May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@kstrenkova kstrenkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your effort :D

@openshift-ci openshift-ci Bot added the lgtm label May 28, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kstrenkova, posikoya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova
Copy link
Copy Markdown
Contributor

kstrenkova commented May 28, 2026

/retest

@openshift-merge-bot openshift-merge-bot Bot merged commit c936983 into openstack-k8s-operators:main May 28, 2026
7 checks passed
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

@posikoya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 74c4f92 link unknown /test images
ci/prow/functional 74c4f92 link unknown /test functional
ci/prow/precommit-check 74c4f92 link unknown /test precommit-check

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kstrenkova kstrenkova kstrenkova approved these changes

@stuggi stuggi Awaiting requested review from stuggi

@dprince dprince Awaiting requested review from dprince

Assignees

@kstrenkova kstrenkova

Labels

approved lgtm ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@posikoya @kstrenkova