Skip to content

requeue logic for pending NAD #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 28, 2026
+22 −2
Merged

requeue logic for pending NAD #445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions internal/controller/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,6 +694,7 @@ func (r *Reconciler) VerifyNetworkAttachments(
conditions *condition.Conditions,
networkAttachmentStatus *map[string][]string,
) (ctrl.Result, error) {
Log := r.GetLogger(ctx)
pod, err := r.GetPodIfExists(ctx, instance, workflowStepIndex)
if pod == nil {
return ctrl.Result{}, err
Expand All @@ -718,14 +719,33 @@ func (r *Reconciler) VerifyNetworkAttachments(
condition.NetworkAttachmentsReadyMessage)
} else {
err := fmt.Errorf("%w: %s", ErrNetworkAttachmentsMismatch, networkAttachments)

// maxWaitTime to wait for NAD that should escalate to a hard error
const maxWaitTime = 5 * time.Minute
elaspedTime := time.Since(pod.GetCreationTimestamp().Time)
if elaspedTime > maxWaitTime {
conditions.Set(condition.FalseCondition(
condition.NetworkAttachmentsReadyCondition,
condition.ErrorReason,
condition.SeverityError,
condition.NetworkAttachmentsReadyErrorMessage,
fmt.Errorf("timed out waiting for network attachments: %w", err).Error()))

return ctrl.Result{}, err
}

conditions.Set(condition.FalseCondition(
condition.NetworkAttachmentsReadyCondition,
condition.ErrorReason,
"NetworkAttachmentsWaiting",
condition.SeverityWarning,
condition.NetworkAttachmentsReadyErrorMessage,
err.Error()))

return ctrl.Result{}, err
Log.Info("Waiting for network attachments to become ready",
"elaspedTime", elaspedTime,
"maxWaitTime", maxWaitTime)

return ctrl.Result{RequeueAfter: time.Second * 10}, nil
Comment thread
kstrenkova marked this conversation as resolved.
}

return ctrl.Result{}, nil
Expand Down
Loading