Consume common templates via CommonTemplates field

Remove duplicated templates from the operator and consume them
from lib-common via the CommonTemplates field. This allows
maintaining common configuration files (e.g. ssl.conf) in a
single location across all operators.

Signed-off-by: Francesco Pantano <fpantano@redhat.com>

Author: fmount

internal/controller/watcher_common.go

@@ -309,6 +309,7 @@ func GenerateConfigsGeneric(
 	customData map[string]string,
 	cmLabels map[string]string,
 	scripts bool,
+	commonTemplates []string,
 ) error {
 
 	extraTemplates := map[string]string{
@@ -327,6 +328,7 @@ func GenerateConfigsGeneric(
 			CustomData:         customData,
 			Labels:             cmLabels,
 			AdditionalTemplate: extraTemplates,
+			CommonTemplates:    commonTemplates,
 		},
 	}
 	if scripts {

internal/controller/watcher_controller.go

@@ -948,7 +948,7 @@ func (r *WatcherReconciler) generateServiceConfigDBJobs(
 		templateParameters["ACSecret"] = acData.Secret
 	}
 
-	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, true)
+	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, true, []string{})
 }
 
 func (r *WatcherReconciler) ensureDBSync(

internal/controller/watcherapi_controller.go

@@ -513,7 +513,7 @@ func (r *WatcherAPIReconciler) generateServiceConfigs(
 	}
 	templateParameters["VHosts"] = httpdVhostConfig
 
-	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false)
+	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false, []string{"ssl.conf"})
 }
 
 func (r *WatcherAPIReconciler) ensureDeployment(

internal/controller/watcherapplier_controller.go

@@ -458,7 +458,7 @@ func (r *WatcherApplierReconciler) generateServiceConfigs(
 		templateParameters["MemcachedAuthCa"] = fmt.Sprint(memcachedv1.CaMountPath())
 	}
 
-	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false)
+	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false, []string{})
 }
 
 // SetupWithManager sets up the controller with the Manager.

internal/controller/watcherdecisionengine_controller.go

@@ -609,7 +609,7 @@ func (r *WatcherDecisionEngineReconciler) generateServiceConfigs(
 		templateParameters["MemcachedAuthCa"] = fmt.Sprint(memcachedv1.CaMountPath())
 	}
 
-	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false)
+	return GenerateConfigsGeneric(ctx, helper, instance, envVars, templateParameters, customData, labels, false, []string{})
 }
 
 func (r *WatcherDecisionEngineReconciler) ensureDeployment(