Remove deprecated webhook.Defaulter/Validator interface assertions

These compile-time assertions reference webhook.Defaulter and
webhook.Validator interfaces that are removed in controller-runtime
v0.21 (OCP 4.20). The assertions are dead code — webhook registration
already uses CustomDefaulter/CustomValidator in internal/webhook/.

Removing them makes the API module forward-compatible with CR v0.21
so that consumers (like openstack-operator) can bump controller-runtime
without needing replace directives for this operator.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>

Author: stuggi

api/v1beta1/watcher_webhook.go

@@ -27,7 +27,6 @@ import (
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	"k8s.io/utils/ptr"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
@@ -49,8 +48,6 @@ func SetupWatcherDefaults(defaults WatcherDefaults) {
 	watcherlog.Info("Watcher defaults initialized", "defaults", defaults)
 }
 
-var _ webhook.Defaulter = &Watcher{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *Watcher) Default() {
 	watcherlog.Info("default", "name", r.Name)
@@ -108,8 +105,6 @@ func (spec *WatcherSpecCore) getDeprecatedFields(old *WatcherSpecCore) []common_
 	return deprecatedFields
 }
 
-var _ webhook.Validator = &Watcher{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *Watcher) ValidateCreate() (admission.Warnings, error) {
 	watcherlog.Info("validate create", "name", r.Name)

api/v1beta1/watcherapi_webhook.go

@@ -21,7 +21,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
@@ -30,8 +29,6 @@ var watcherapilog = logf.Log.WithName("watcherapi-resource")
 
 // TODO(user): EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
 
-var _ webhook.Defaulter = &WatcherAPI{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *WatcherAPI) Default() {
 	watcherapilog.Info("default", "name", r.Name)
@@ -41,8 +38,6 @@ func (r *WatcherAPI) Default() {
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 
-var _ webhook.Validator = &WatcherAPI{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *WatcherAPI) ValidateCreate() (admission.Warnings, error) {
 	watcherapilog.Info("validate create", "name", r.Name)

api/v1beta1/watcherapplier_webhook.go

@@ -21,7 +21,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
@@ -30,8 +29,6 @@ var watcherapplierlog = logf.Log.WithName("watcherapplier-resource")
 
 // TODO(user): EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
 
-var _ webhook.Defaulter = &WatcherApplier{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *WatcherApplier) Default() {
 	watcherapplierlog.Info("default", "name", r.Name)
@@ -41,8 +38,6 @@ func (r *WatcherApplier) Default() {
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 
-var _ webhook.Validator = &WatcherApplier{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *WatcherApplier) ValidateCreate() (admission.Warnings, error) {
 	watcherapplierlog.Info("validate create", "name", r.Name)

api/v1beta1/watcherdecisionengine_webhook.go

@@ -21,7 +21,6 @@ import (
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/validation/field"
 	logf "sigs.k8s.io/controller-runtime/pkg/log"
-	"sigs.k8s.io/controller-runtime/pkg/webhook"
 	"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
 )
 
@@ -30,8 +29,6 @@ var watcherdecisionenginelog = logf.Log.WithName("watcherdecisionengine-resource
 
 // TODO(user): EDIT THIS FILE!  THIS IS SCAFFOLDING FOR YOU TO OWN!
 
-var _ webhook.Defaulter = &WatcherDecisionEngine{}
-
 // Default implements webhook.Defaulter so a webhook will be registered for the type
 func (r *WatcherDecisionEngine) Default() {
 	watcherdecisionenginelog.Info("default", "name", r.Name)
@@ -41,8 +38,6 @@ func (r *WatcherDecisionEngine) Default() {
 
 // TODO(user): change verbs to "verbs=create;update;delete" if you want to enable deletion validation.
 
-var _ webhook.Validator = &WatcherDecisionEngine{}
-
 // ValidateCreate implements webhook.Validator so a webhook will be registered for the type
 func (r *WatcherDecisionEngine) ValidateCreate() (admission.Warnings, error) {
 	watcherdecisionenginelog.Info("validate create", "name", r.Name)