Skip to content

Remove unnecessary pods RBAC permissions - #409

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods
Jul 24, 2026
Merged

Remove unnecessary pods RBAC permissions#409
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods

Conversation

@stuggi

@stuggi stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The workload rbacRules and kubebuilder RBAC markers granted the operator and its workload service account full CRUD (create/delete/get/list/patch/update/ watch) on core Pods, but the operator never reads or writes Pod objects directly — pods only ever come into being indirectly via Deployments/ StatefulSets/Jobs. Remove the unused pods permission and regenerate config/rbac/role.yaml.

The workload rbacRules and kubebuilder RBAC markers granted the operator and
its workload service account full CRUD (create/delete/get/list/patch/update/
watch) on core Pods, but the operator never reads or writes Pod objects
directly — pods only ever come into being indirectly via Deployments/
StatefulSets/Jobs. Remove the unused pods permission and regenerate
config/rbac/role.yaml.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci
openshift-ci Bot requested review from raukadah and rlandy July 24, 2026 14:10

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/3f2d4b80a83c436090642d6a573d3fed

✔️ openstack-meta-content-provider-master SUCCESS in 3h 09m 23s
✔️ watcher-operator-validation-master SUCCESS in 2h 25m 05s
openstack-meta-content-provider-epoxy FAILURE in 22m 10s
⚠️ watcher-operator-validation-epoxy SKIPPED Skipped due to failed job openstack-meta-content-provider-epoxy
⚠️ watcher-operator-validation-epoxy-ocp4-18 SKIPPED Skipped due to failed job openstack-meta-content-provider-epoxy
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 1h 00m 54s

@amoralej

Copy link
Copy Markdown
Contributor

check-rdo

@abays abays added the approved label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 778e771 into openstack-k8s-operators:main Jul 24, 2026
7 checks passed
@stuggi

stuggi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick 18-stable

@openshift-cherrypick-robot

Copy link
Copy Markdown

@stuggi: new pull request created: #422

Details

In response to this:

/cherry-pick 18-stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants