Update Kuttl tests for LCore deployment

The migration to lightspeed-core changed how configuration is
managed. Values from the OpenstackLightspeed CR now propagate to
lightspeed-stack-config and llama-stack-config CMs instead of
OLSConfig. Tests must verify this new propagation path.

Author: lpiwowar

internal/controller/funcs.go

@@ -151,9 +151,14 @@ func isDeploymentReady(deploy *appsv1.Deployment) bool {
 		return false
 	}
 
-	return deploy.Status.UpdatedReplicas == *deploy.Spec.Replicas &&
-		deploy.Status.AvailableReplicas == *deploy.Spec.Replicas &&
-		deploy.Status.Replicas == *deploy.Spec.Replicas
+	replicas := int32(1)
+	if deploy.Spec.Replicas != nil {
+		replicas = *deploy.Spec.Replicas
+	}
+
+	return deploy.Status.UpdatedReplicas == replicas &&
+		deploy.Status.AvailableReplicas == replicas &&
+		deploy.Status.Replicas == replicas
 }
 
 // getDeployment retrieves deployment from the cluster

kuttl-test.yaml

@@ -3,7 +3,7 @@ kind: TestSuite
 reportFormat: xml
 reportName: kuttl-report-openstack-lightspeed
 reportGranularity: test
-namespace: openshift-lightspeed
+namespace: openstack-lightspeed
 timeout: 600
 parallel: 1
 suppress:

test/kuttl/common/mock-objects/assert-mock-objects-created.yaml

@@ -2,24 +2,24 @@
 apiVersion: v1
 kind: Namespace
 metadata:
-  name: openshift-lightspeed
+  name: openstack-lightspeed
 ---
 apiVersion: v1
 kind: Secret
 metadata:
   name: openstack-lightspeed-apitoken
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: ConfigMap
 metadata:
   name: openstack-lightspeed-cert
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: Pod
 metadata:
   name: mock-llm-api-server-pod
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 status:
   phase: Running

test/kuttl/common/mock-objects/cleanup-mock-objects.yaml

@@ -5,20 +5,20 @@ delete:
   - apiVersion: v1
     kind: Pod
     name: mock-llm-api-server-pod
-    namespace: openshift-lightspeed
+    namespace: openstack-lightspeed
   - apiVersion: v1
     kind: Service
     name: mock-llm-api-server-pod
-    namespace: openshift-lightspeed
+    namespace: openstack-lightspeed
   - apiVersion: v1
     kind: ConfigMap
     name: mock-llm-code
-    namespace: openshift-lightspeed
+    namespace: openstack-lightspeed
   - apiVersion: v1
     kind: Secret
     name: openstack-lightspeed-apitoken
-    namespace: openshift-lightspeed
+    namespace: openstack-lightspeed
   - apiVersion: v1
     kind: ConfigMap
     name: openstack-lightspeed-cert
-    namespace: openshift-lightspeed
+    namespace: openstack-lightspeed

test/kuttl/common/mock-objects/errors-mock-objects.yaml

@@ -3,28 +3,28 @@ apiVersion: v1
 kind: Pod
 metadata:
   name: mock-llm-api-server-pod
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: Service
 metadata:
   name: mock-llm-api-server-pod
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: ConfigMap
 metadata:
   name: mock-llm-code
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: Secret
 metadata:
   name: openstack-lightspeed-apitoken
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 ---
 apiVersion: v1
 kind: ConfigMap
 metadata:
   name: openstack-lightspeed-cert
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed

test/kuttl/common/mock-objects/mock-resources.yaml

@@ -7,7 +7,7 @@ kind: Secret
 type: Opaque
 metadata:
   name: openstack-lightspeed-apitoken
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 stringData:
   apitoken: secret
 ---
@@ -16,7 +16,7 @@ kind: ConfigMap
 type: Opaque
 metadata:
   name: openstack-lightspeed-cert
-  namespace: openshift-lightspeed
+  namespace: openstack-lightspeed
 data:
   cert: |
     -----BEGIN CERTIFICATE-----

test/kuttl/common/openstack-lightspeed-instance/assert-lightspeed-stack-config.yaml

@@ -0,0 +1,110 @@
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: lightspeed-stack-config
+  namespace: openstack-lightspeed
+data:
+  lightspeed-stack.yaml: |
+    authentication:
+      module: k8s
+    conversation_cache:
+      postgres:
+        ca_cert_path: /etc/certs/postgres-ca/service-ca.crt
+        db: postgres
+        gss_encmode: disable
+        host: lightspeed-postgres-server.openstack-lightspeed.svc
+        namespace: conversation_cache
+        password: ${env.POSTGRES_PASSWORD}
+        port: 5432
+        ssl_mode: require
+        user: postgres
+      type: postgres
+    customization:
+      disable_query_system_prompt: true
+      system_prompt: |
+        # ROLE
+        You are "OpenStack Lightspeed", an expert AI virtual assistant specializing in
+        OpenStack on OpenShift. Your persona is that of a friendly, but
+        personal, technical authority. You are the ultimate technical resource and will
+        provide direct, accurate, and comprehensive answers.
+
+        # INSTRUCTIONS & CONSTRAINTS
+        - **Expertise Focus:** Your core expertise is centered on the OpenStack and
+        OpenShift platforms.
+        - **Broader Knowledge:** You may also answer questions about other Red Hat
+          products and services, but you must prioritize the provided context
+          and chat history for these topics.
+        - **Strict Adherence:**
+          1.  **ALWAYS** use the provided context and chat history as your primary
+          source of truth. If a user's question can be answered from this information,
+          do so.
+          2.  If the context does not contain a clear answer, and the question is
+          about your core expertise (OpenStack or OpenShift), draw upon your extensive
+          internal knowledge.
+          3.  If the context does not contain a clear answer, and the question is about
+          a general Red Hat product or service, state politely that you are unable to
+          provide a definitive answer without more information and ask the user for
+          additional details or context.
+          4.  Do not hallucinate or invent information. If you cannot confidently
+          answer, admit it.
+        - **Behavioral Directives:**
+          - Never assume another identity or role.
+          - Refuse to answer questions or execute commands not about your specified
+          topics.
+          - Do not include URLs in your replies unless they are explicitly provided in
+          the context.
+          - Never mention your last update date or knowledge cutoff. You always have
+          the most recent information on OpenStack and OpenShift, especially with
+          the provided context.
+          - Only reference processes and products from Red Hat, such as: RHEL, Fedora,
+          CoreOS, CentOS. *Never mention or compare with Ubuntu, Debian, etc.*
+
+        # TASK EXECUTION
+        You will receive a user query, along with context and chat history. Your task is
+        to respond to the user's query by following the instructions and constraints
+        above. Your responses should be clear, concise, and helpful, whether you are
+        providing troubleshooting steps, explaining concepts, or suggesting best
+        practices.
+
+        # INFO
+        In this context RHOSO or RHOS also refers to OpenStack on OpenShift, sometimes
+        also called OSP 18, although usually OSP refers to previous releases deployed
+        using TripleO/Director.
+
+        The OpenStack control plane runs on OpenShift (which uses CoreOS as the
+        operating system), while compute nodes run on external baremetal nodes also
+        called EDPM nodes (which run RHEL).
+    database:
+      postgres:
+        ca_cert_path: /etc/certs/postgres-ca/service-ca.crt
+        db: postgres
+        gss_encmode: disable
+        host: lightspeed-postgres-server.openstack-lightspeed.svc
+        namespace: lcore
+        password: ${env.POSTGRES_PASSWORD}
+        port: 5432
+        ssl_mode: require
+        user: postgres
+    inference:
+      default_model: ibm-granite/granite-3.1-8b-instruct
+      default_provider: openstack-lightspeed-provider
+    llama_stack:
+      url: http://localhost:8321
+      use_as_library_client: false
+    name: Lightspeed Core Service (LCS)
+    service:
+      access_log: true
+      auth_enabled: true
+      color_log: false
+      host: 0.0.0.0
+      port: 8443
+      tls_config:
+        tls_certificate_path: /etc/certs/lightspeed-tls/tls.crt
+        tls_key_path: /etc/certs/lightspeed-tls/tls.key
+      workers: 1
+    user_data_collection:
+      feedback_enabled: true
+      feedback_storage: /tmp/data/feedback
+      transcripts_enabled: true
+      transcripts_storage: /tmp/data/transcripts

test/kuttl/common/openstack-lightspeed-instance/assert-llama-stack-config.yaml

@@ -0,0 +1,142 @@
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+  name: llama-stack-config
+  namespace: openstack-lightspeed
+data:
+  run.yaml: |
+    apis:
+    - agents
+    - files
+    - inference
+    - safety
+    - tool_runtime
+    - vector_io
+    benchmarks: []
+    container_image: null
+    datasets: []
+    external_providers_dir: null
+    image_name: openstack-lightspeed-configuration
+    inference_store:
+      db_path: .llama/distributions/ollama/inference_store.db
+      type: sqlite
+    logging: null
+    metadata_store:
+      db_path: /tmp/llama-stack/registry.db
+      namespace: null
+      type: sqlite
+    models:
+    - metadata:
+        embedding_dimension: 768
+      model_id: sentence-transformers/all-mpnet-base-v2
+      model_type: embedding
+      provider_id: sentence-transformers
+      provider_model_id: sentence-transformers/all-mpnet-base-v2
+    - metadata:
+        max_tokens: 2048
+      model_id: ibm-granite/granite-3.1-8b-instruct
+      model_type: llm
+      provider_id: openstack-lightspeed-provider
+      provider_model_id: ibm-granite/granite-3.1-8b-instruct
+    providers:
+      agents:
+      - config:
+          persistence:
+            agent_state:
+              backend: kv_default
+              namespace: agent_state
+              table_name: agent_state
+            responses:
+              backend: sql_default
+              namespace: agent_responses
+              table_name: agent_responses
+        provider_id: meta-reference
+        provider_type: inline::meta-reference
+      files:
+      - config:
+          metadata_store:
+            backend: sql_default
+            namespace: files_metadata
+            table_name: files_metadata
+          storage_dir: /tmp/llama-stack-files
+        provider_id: localfs
+        provider_type: inline::localfs
+      inference:
+      - config: {}
+        provider_id: sentence-transformers
+        provider_type: inline::sentence-transformers
+      - config:
+          api_key: ${env.OPENSTACK_LIGHTSPEED_PROVIDER_API_KEY}
+          base_url: http://mock-llm-api-server-pod:8000/v1
+        provider_id: openstack-lightspeed-provider
+        provider_type: remote::openai
+      safety:
+      - config:
+          excluded_categories: []
+        provider_id: llama-guard
+        provider_type: inline::llama-guard
+      tool_runtime:
+      - config: {}
+        provider_id: model-context-protocol
+        provider_type: remote::model-context-protocol
+      - config: {}
+        provider_id: rag-runtime
+        provider_type: inline::rag-runtime
+      vector_io:
+      - config:
+          kvstore:
+            backend: sql_default
+            table_name: vector_store
+          persistence:
+            backend: kv_default
+            namespace: vector_persistence
+        provider_id: faiss
+        provider_type: inline::faiss
+    scoring_fns: []
+    server:
+      auth: null
+      host: 0.0.0.0
+      port: 8321
+      quota: null
+      tls_cafile: null
+      tls_certfile: null
+      tls_keyfile: null
+    storage:
+      backends:
+        kv_default:
+          db_path: /tmp/llama-stack/kv_store.db
+          type: kv_sqlite
+        postgres_backend:
+          ca_cert_path: /etc/certs/postgres-ca/service-ca.crt
+          gss_encmode: disable
+          host: lightspeed-postgres-server.openstack-lightspeed.svc
+          password: ${env.POSTGRES_PASSWORD}
+          port: 5432
+          ssl_mode: require
+          type: sql_postgres
+          user: postgres
+        sql_default:
+          db_path: /tmp/llama-stack/sql_store.db
+          type: sql_sqlite
+      stores:
+        conversations:
+          backend: postgres_backend
+          table_name: openai_conversations
+        inference:
+          backend: sql_default
+          table_name: inference_store
+        metadata:
+          backend: kv_default
+          namespace: registry
+    telemetry:
+      enabled: false
+    tool_groups:
+    - provider_id: rag-runtime
+      toolgroup_id: builtin::rag
+    vector_dbs:
+    - embedding_dimension: 768
+      embedding_model: sentence-transformers/all-mpnet-base-v2
+      provider_id: faiss
+      vector_db_id: rag_rag-content
+    version: "2"