Commit deb3411
Console: Add OpenShift->OpenStack text replacement
To avoid having the console saying it's OpenShift Lightspeed we will be
doing a replacement of the OpenShift word in the internationalization
file.
This mechanism is a bit hacky, but it's a patch that's easy to revert if
we decide to.
Add an init container that rewrites "OpenShift" references to
"OpenStack" in the locales JSON file using awk.
The awk script splits each line at the key-value boundary and only
replaces in values, preserving i18n lookup keys.
Using this mechanism should not be a problem for non English locales (at
least according to Claude), since the i18n fallback mechanism works like
this:
1. This plugin doesn't initialize i18next itself. It relies on the
parent OpenShift Console (via ConsoleRemotePlugin in
webpack.config.ts) to set up i18next globally. The plugin just uses
useTranslation('plugin__lightspeed-console-plugin') to access its
namespace.
2. When a non-English locale is requested, i18next looks for
locales/<locale>/plugin__lightspeed-console-plugin.json. Since only
locales/en/ exists, i18next falls back to English — this is standard
i18next behavior where missing locale files cause a fallback to the
default language.
3. Additionally, the translation keys in
locales/en/plugin__lightspeed-console-plugin.json are the English
strings themselves (e.g., "Close": "Close"). So even if the fallback
mechanism somehow failed entirely, i18next's last resort is to
display the key as-is — which in this case is already readable
English text.
As long as OLS console doesn't have a bug in their code that doesn't use
the internationalization with a string and that string has OpenShift in
the wording we should be fine.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent db1d31d commit deb3411
4 files changed
Lines changed: 128 additions & 3 deletions
File tree
- internal/controller
- test/kuttl
- common/openstack-lightspeed-instance
- tests/update-openstacklightspeed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
41 | 61 | | |
| 62 | + | |
| 63 | + | |
42 | 64 | | |
43 | 65 | | |
44 | 66 | | |
| |||
55 | 77 | | |
56 | 78 | | |
57 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
58 | 97 | | |
59 | 98 | | |
60 | 99 | | |
| |||
83 | 122 | | |
84 | 123 | | |
85 | 124 | | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
86 | 131 | | |
87 | 132 | | |
88 | 133 | | |
| |||
113 | 158 | | |
114 | 159 | | |
115 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
116 | 167 | | |
117 | 168 | | |
118 | 169 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | | - | |
| 82 | + | |
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
88 | | - | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
89 | 103 | | |
90 | 104 | | |
91 | 105 | | |
| |||
129 | 143 | | |
130 | 144 | | |
131 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
132 | 190 | | |
133 | 191 | | |
134 | 192 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
156 | 164 | | |
157 | 165 | | |
158 | 166 | | |
| |||
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
106 | 114 | | |
107 | 115 | | |
108 | 116 | | |
| |||
0 commit comments