Skip to content

Lcore dev improvements#125

Open
Akrog wants to merge 3 commits into
openstack-lightspeed:lcore-migrationfrom
Akrog:lcore-dev-improvements
Open

Lcore dev improvements#125
Akrog wants to merge 3 commits into
openstack-lightspeed:lcore-migrationfrom
Akrog:lcore-dev-improvements

Conversation

@Akrog

@Akrog Akrog commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Just some small improvements for developers:

  • ocp-deploy and ocp-deploy-cleanup targets
  • GOMAXPROCS support to limit parallel processes during golang compilation
  • Add kuttl test artifacts to .gitignore

Summary by CodeRabbit

  • New Features

    • Improved OpenShift deployment flow with a new cleanup step for registry/catalog resources.
    • Added stronger teardown behavior to remove deployed application resources more completely.
  • Bug Fixes

    • Build and container image creation now propagate CPU settings more consistently, helping ensure more reliable builds in different environments.
  • Chores

    • Updated ignored test artifacts so temporary KUTTL files are no longer tracked.

Akrog added 3 commits June 24, 2026 17:42
Simply ignore the `kubeconfig` and
`kuttl-report-openstack-lightspeed.xml` files that are generated during
a kuttl test run (eg: `make kuttl-test-ocp`).
Similar to `kuttl-test-ocp` that deploys and runs kuttl we now add a
couple of convenient make targets to help development:

- `ocp-deploy`
- `ocp-deploy-cleanup`
Right now when we build the container (make docker-build) or the
controller (make build) the go compiler will try to use all the CPUs on
the machine.

This can become problematic in some systems that may suffer starvation
(eg: audio problems), so we add support for the `GOMAXPROCS` env var to
be passed to those 2 make targets.
@openshift-ci openshift-ci Bot requested review from lpiwowar and umago June 24, 2026 15:48
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: aeb5534d-0085-4fa3-832d-ebb3953ae526

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant