Rename parameters to match implemented interfaces so <inheritdoc/> works properly

Author: sharwell

src/corelib/Providers/Rackspace/CloudFilesProvider.cs

@@ -423,7 +423,7 @@ public ContainerCDN GetContainerCDNHeader(string container, string region = null
         }
 
         /// <inheritdoc />
-        public IEnumerable<ContainerCDN> ListCDNContainers(int? limit = null, string marker = null, string markerEnd = null, bool cdnEnabled = false, string region = null, CloudIdentity identity = null)
+        public IEnumerable<ContainerCDN> ListCDNContainers(int? limit = null, string markerId = null, string markerEnd = null, bool cdnEnabled = false, string region = null, CloudIdentity identity = null)
         {
             if (limit < 0)
                 throw new ArgumentOutOfRangeException("limit");
@@ -440,8 +440,8 @@ public IEnumerable<ContainerCDN> ListCDNContainers(int? limit = null, string mar
             if (limit != null)
                 queryStringParameter.Add("limit", limit.ToString());
 
-            if (!string.IsNullOrEmpty(marker))
-                queryStringParameter.Add("marker", marker);
+            if (!string.IsNullOrEmpty(markerId))
+                queryStringParameter.Add("marker", markerId);
 
             if (!string.IsNullOrEmpty(markerEnd))
                 queryStringParameter.Add("end_marker", markerEnd);
@@ -557,17 +557,17 @@ public void UpdateContainerMetadata(string container, Dictionary<string, string>
         }
 
         /// <inheritdoc />
-        public void DeleteContainerMetadata(string container, IEnumerable<string> metadata, string region = null, bool useInternalUrl = false, CloudIdentity identity = null)
+        public void DeleteContainerMetadata(string container, IEnumerable<string> keys, string region = null, bool useInternalUrl = false, CloudIdentity identity = null)
         {
             if (container == null)
                 throw new ArgumentNullException("container");
-            if (metadata == null)
-                throw new ArgumentNullException("metadata");
+            if (keys == null)
+                throw new ArgumentNullException("keys");
             if (string.IsNullOrEmpty(container))
                 throw new ArgumentException("container cannot be empty");
             CheckIdentity(identity);
 
-            Dictionary<string, string> headers = metadata.ToDictionary(i => i, i => default(string), StringComparer.OrdinalIgnoreCase);
+            Dictionary<string, string> headers = keys.ToDictionary(i => i, i => default(string), StringComparer.OrdinalIgnoreCase);
             UpdateContainerMetadata(container, headers, region, useInternalUrl, identity);
         }
 

src/corelib/Providers/Rackspace/CloudIdentityProvider.cs

@@ -595,40 +595,40 @@ public virtual IEnumerable<User> GetUsersByEmail(string email, CloudIdentity ide
         }
 
         /// <inheritdoc/>
-        public virtual User GetUser(string userId, CloudIdentity identity)
+        public virtual User GetUser(string id, CloudIdentity identity)
         {
-            if (userId == null)
-                throw new ArgumentNullException("userId");
-            if (string.IsNullOrEmpty(userId))
-                throw new ArgumentException("userId cannot be empty");
+            if (id == null)
+                throw new ArgumentNullException("id");
+            if (string.IsNullOrEmpty(id))
+                throw new ArgumentException("id cannot be empty");
             CheckIdentity(identity);
 
-            var urlPath = string.Format("v2.0/users/{0}", userId);
+            var urlPath = string.Format("v2.0/users/{0}", id);
 
             var response = ExecuteRESTRequest<UserResponse>(identity, new Uri(UrlBase, urlPath), HttpMethod.GET);
 
             return response.Data.User;
         }
 
         /// <inheritdoc/>
-        public virtual NewUser AddUser(NewUser newUser, CloudIdentity identity)
+        public virtual NewUser AddUser(NewUser user, CloudIdentity identity)
         {
-            if (newUser == null)
-                throw new ArgumentNullException("newUser");
-            if (string.IsNullOrEmpty(newUser.Username))
-                throw new ArgumentException("newUser.Username cannot be null or empty");
-            if (newUser.Id != null)
-                throw new InvalidOperationException("newUser.Id must be null");
+            if (user == null)
+                throw new ArgumentNullException("user");
+            if (string.IsNullOrEmpty(user.Username))
+                throw new ArgumentException("user.Username cannot be null or empty");
+            if (user.Id != null)
+                throw new InvalidOperationException("user.Id must be null");
             CheckIdentity(identity);
 
-            var response = ExecuteRESTRequest<NewUserResponse>(identity, new Uri(UrlBase, "/v2.0/users"), HttpMethod.POST, new AddUserRequest(newUser));
+            var response = ExecuteRESTRequest<NewUserResponse>(identity, new Uri(UrlBase, "/v2.0/users"), HttpMethod.POST, new AddUserRequest(user));
 
             if (response == null || response.Data == null)
                 return null;
 
             // If the user specifies a password, then the password will not be in the response, so we need to fill it in on the return object.
             if (string.IsNullOrEmpty(response.Data.NewUser.Password))
-                response.Data.NewUser.Password = newUser.Password;
+                response.Data.NewUser.Password = user.Password;
 
             return response.Data.NewUser;
         }

src/corelib/Providers/Rackspace/IDnsService.cs

@@ -471,7 +471,7 @@ public interface IDnsService
         /// Removes one or more domain records from the DNS service.
         /// </summary>
         /// <param name="domainId">The domain ID. This is obtained from <see cref="DnsDomain.Id">DnsDomain.Id</see>.</param>
-        /// <param name="recordId">A collection of IDs for the records to remove. These are obtained from <see cref="DnsRecord.Id">DnsRecord.Id</see>.</param>
+        /// <param name="recordIds">A collection of IDs for the records to remove. These are obtained from <see cref="DnsRecord.Id">DnsRecord.Id</see>.</param>
         /// <param name="completionOption">Specifies when the <see cref="Task"/> representing the asynchronous server operation should be considered complete.</param>
         /// <param name="cancellationToken">The <see cref="CancellationToken"/> that the task will observe.</param>
         /// <param name="progress">An optional callback object to receive progress notifications, if <paramref name="completionOption"/> is <see cref="AsyncCompletionOption.RequestCompleted"/>. If this is <see langword="null"/>, no progress notifications are sent.</param>
@@ -491,16 +491,16 @@ public interface IDnsService
         /// <exception cref="ArgumentNullException">
         /// If <paramref name="domainId"/> is <see langword="null"/>.
         /// <para>-or-</para>
-        /// <para>If <paramref name="recordId"/> is <see langword="null"/>.</para>
+        /// <para>If <paramref name="recordIds"/> is <see langword="null"/>.</para>
         /// </exception>
         /// <exception cref="ArgumentException">
-        /// If <paramref name="recordId"/> contains any <see langword="null"/> values.
+        /// If <paramref name="recordIds"/> contains any <see langword="null"/> values.
         /// <para>-or-</para>
         /// <para>If <paramref name="completionOption"/> is not a valid <see cref="AsyncCompletionOption"/>.</para>
         /// </exception>
         /// <exception cref="WebException">If the REST request does not return successfully.</exception>
         /// <seealso href="http://docs.rackspace.com/cdns/api/v1.0/cdns-devguide/content/Remove_Records-d1e5188.html">Remove Records (Rackspace Cloud DNS Developer Guide - API v1.0)</seealso>
-        Task<DnsJob> RemoveRecordsAsync(DomainId domainId, IEnumerable<RecordId> recordId, AsyncCompletionOption completionOption, CancellationToken cancellationToken, IProgress<DnsJob> progress);
+        Task<DnsJob> RemoveRecordsAsync(DomainId domainId, IEnumerable<RecordId> recordIds, AsyncCompletionOption completionOption, CancellationToken cancellationToken, IProgress<DnsJob> progress);
 
         #endregion