Skip to content

Commit b4abbb8

Browse files
committed
Fix serialization tests
1 parent 71c0016 commit b4abbb8

File tree

4 files changed

+16
-14
lines changed

4 files changed

+16
-14
lines changed

src/corelib/Compute/v2_6/Console.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
using System;
2+
using Newtonsoft.Json;
23
using OpenStack.Serialization;
34

45
namespace OpenStack.Compute.v2_6
@@ -12,11 +13,13 @@ public class Console
1213
/// <summary>
1314
/// The console type.
1415
/// </summary>
16+
[JsonProperty("type")]
1517
public RemoteConsoleType Type { get; set; }
1618

1719
/// <summary>
1820
/// The console URL.
1921
/// </summary>
22+
[JsonProperty("url")]
2023
public Uri Url { get; set; }
2124
}
2225
}

src/testing/unit/ContentDeliveryNetworks/v1/ServiceTests.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public void SerializeServiceCollection()
3232
Items = {new Service {Id = "service-id"}},
3333
Links = {new PageLink("next", "http://api.com/next")}
3434
};
35-
string json = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(services, Formatting.None);
35+
string json = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(services);
3636
Assert.Contains("\"services\"", json);
3737
Assert.DoesNotContain("\"service\"", json);
3838

@@ -48,7 +48,7 @@ public void SerializeServiceCollection()
4848
public void SerializePageLink()
4949
{
5050
var link = new PageLink("next", "http://api.com/next");
51-
string json = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(link, Formatting.None);
51+
string json = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(link);
5252

5353
var result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Deserialize<PageLink>(json);
5454
Assert.NotNull(result);

src/testing/unit/IdentifierTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void Serialize_WithinAClass()
2727
{
2828
var thing = new Thing {Id = Guid.NewGuid()};
2929

30-
var result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(thing, Formatting.None);
30+
var result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(thing);
3131

3232
Assert.Equal(string.Format("{{\"Id\":\"{0}\"}}", thing.Id), result);
3333
}

src/testing/unit/Networking/v2/DHCPOptionConverterTests.cs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
using System.Collections.Generic;
22
using Newtonsoft.Json;
33
using Newtonsoft.Json.Linq;
4-
using OpenStack.Networking.v2.Serialization;
5-
using OpenStack.Serialization;
64
using Xunit;
75

86
namespace OpenStack.Networking.v2
@@ -12,24 +10,27 @@ public class DHCPOptionConverterTests
1210
[Fact]
1311
public void Serialize()
1412
{
15-
var options = new Dictionary<string, string>
13+
var input = new PortCreateDefinition(null)
1614
{
17-
{"a", "stuff"},
18-
{"b", "things"}
15+
DHCPOptions =
16+
{
17+
{"a", "stuff"},
18+
{"b", "things"}
19+
}
1920
};
2021

21-
string result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(options, Formatting.None, new DHCPOptionsConverter());
22+
string result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Serialize(input);
2223

23-
string expectedJson = JArray.Parse("[{'opt_name':'a','opt_value':'stuff'},{'opt_name':'b','opt_value':'things'}]").ToString(Formatting.None);
24+
string expectedJson = JObject.Parse("{'port':{'extra_dhcp_opts':[{'opt_name':'a','opt_value':'stuff'},{'opt_name':'b','opt_value':'things'}]}}").ToString(Formatting.None);
2425
Assert.Equal(expectedJson, result);
2526
}
2627

2728
[Fact]
2829
public void Deserialize()
2930
{
30-
string json = JArray.Parse("[{'opt_name':'a','opt_value':'stuff'},{'opt_name':'b','opt_value':'things'}]").ToString(Formatting.None);
31+
string json = JObject.Parse("{'port':{'extra_dhcp_opts':[{'opt_name':'a','opt_value':'stuff'},{'opt_name':'b','opt_value':'things'}]}}").ToString(Formatting.None);
3132

32-
var result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Deserialize<Dictionary<string, string>>(json, new DHCPOptionsConverter());
33+
var result = OpenStackNet.Configuration.FlurlHttpSettings.JsonSerializer.Deserialize<PortCreateDefinition>(json).DHCPOptions;
3334

3435
Assert.NotNull(result);
3536
Assert.Equal(2, result.Count);
@@ -43,8 +44,6 @@ public void Deserialize()
4344
[Fact]
4445
public void OpenStackNet_UsesDHCPOptionConverter()
4546
{
46-
OpenStackNet.Configure();
47-
4847
var port = new Port
4948
{
5049
DHCPOptions = new Dictionary<string, string>

0 commit comments

Comments
 (0)