chore(lint): add golangci-lint v2 with CI workflow

Configure golangci-lint v2.12.2 with a curated linter set (bodyclose,
errorlint, gocritic, gosec, revive, etc.) plus gofumpt + goimports
formatters. Add a GitHub Actions workflow that runs lint on push and PR.

Tune rule suppressions for CLI idioms (tablewriter result discard, PAGER
subprocess, urfave/cli int casts, proto Id/Url naming). Apply
golangci-lint --fix across 59 files for whitespace, gofumpt, and
staticcheck rewrites; tests still pass.

Author: thibaultleouay

.github/workflows/lint.yml

@@ -0,0 +1,29 @@
+name: Lint
+
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - '**'
+
+permissions:
+  contents: read
+  pull-requests: read
+
+jobs:
+  golangci-lint:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - uses: actions/checkout@v6
+      - uses: actions/setup-go@v6
+        with:
+          go-version: stable
+          cache: false
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v9
+        with:
+          version: v2.12.2

.golangci.yml

@@ -0,0 +1,100 @@
+version: "2"
+
+run:
+  timeout: 5m
+  modules-download-mode: readonly
+
+linters:
+  default: standard
+  enable:
+    - bodyclose
+    - copyloopvar
+    - errorlint
+    - gocritic
+    - gosec
+    - misspell
+    - nolintlint
+    - revive
+    - unconvert
+    - unparam
+    - usestdlibvars
+    - whitespace
+
+  settings:
+    errcheck:
+      exclude-functions:
+        - (*github.com/olekukonko/tablewriter.Table).Bulk
+        - (*github.com/olekukonko/tablewriter.Table).Render
+        - (*os/exec.Cmd).Wait
+        - github.com/joho/godotenv.Load
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - performance
+        - style
+      disabled-checks:
+        - appendCombine
+        - commentedOutCode
+        - hugeParam
+        - ifElseChain
+        - importShadow
+        - paramTypeCombine
+        - rangeValCopy
+        - unlambda # test seams use this pattern
+        - unnamedResult
+    gosec:
+      excludes:
+        - G104 # duplicated by errcheck
+        - G115 # int->int32 narrowing for proto/API fields is intentional
+    revive:
+      rules:
+        - name: blank-imports
+        - name: context-as-argument
+        - name: context-keys-type
+        - name: error-return
+        - name: error-strings
+        - name: error-naming
+        - name: increment-decrement
+        - name: range
+        - name: receiver-naming
+        - name: redefines-builtin-id
+        - name: superfluous-else
+        - name: time-naming
+        - name: unexported-return
+          disabled: true # CLI internals return unexported result types
+        - name: unreachable-code
+        - name: unused-parameter
+          disabled: true
+        - name: var-naming
+          disabled: true # conflicts with generated proto identifiers (Id, Url, …)
+
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - path: _test\.go
+        linters:
+          - errcheck
+          - gocritic
+          - gosec
+          - unparam
+      - path: internal/cli/pager\.go
+        linters:
+          - gosec # G204: PAGER env var is the standard CLI pattern
+      # int(cmd.Int(...)) idiom from urfave/cli/v3 and int64() casts of proto ints
+      - linters:
+          - unconvert
+        text: unnecessary conversion
+
+formatters:
+  enable:
+    - gofumpt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/openstatusHQ/cli

cmd/docs/docs.go

@@ -3,8 +3,9 @@ package main
 import (
 	"os"
 
-	cmd "github.com/openstatusHQ/cli/internal/cmd"
 	docs "github.com/urfave/cli-docs/v3"
+
+	cmd "github.com/openstatusHQ/cli/internal/cmd"
 )
 
 func main() {

cmd/openstatus/main.go

@@ -1,9 +1,11 @@
 package main
 
 import (
+	"log"
+
 	"github.com/joho/godotenv"
+
 	cmd "github.com/openstatusHQ/cli/internal/cmd"
-	"log"
 )
 
 func main() {

internal/api/client.go

@@ -8,6 +8,7 @@ import (
 	"time"
 
 	"connectrpc.com/connect"
+
 	output "github.com/openstatusHQ/cli/internal/cli"
 )
 

internal/auth/auth.go

@@ -5,8 +5,9 @@ import (
 	"os"
 	"strings"
 
-	"github.com/openstatusHQ/cli/internal/config"
 	clilib "github.com/urfave/cli/v3"
+
+	"github.com/openstatusHQ/cli/internal/config"
 )
 
 // ResolveAccessToken extracts the access token from CLI flags or falls back to saved token.
@@ -40,7 +41,7 @@ func SaveToken(token string) error {
 	if err != nil {
 		return fmt.Errorf("failed to determine config directory: %w", err)
 	}
-	if err := os.MkdirAll(dir, 0700); err != nil {
+	if err := os.MkdirAll(dir, 0o700); err != nil {
 		return fmt.Errorf("failed to create config directory: %w", err)
 	}
 
@@ -64,7 +65,7 @@ func SaveToken(token string) error {
 		os.Remove(tmpPath)
 		return fmt.Errorf("failed to close temp file: %w", err)
 	}
-	if err := os.Chmod(tmpPath, 0600); err != nil {
+	if err := os.Chmod(tmpPath, 0o600); err != nil {
 		os.Remove(tmpPath)
 		return fmt.Errorf("failed to set token file permissions: %w", err)
 	}

internal/cli/output.go

@@ -26,9 +26,11 @@ func IsDebug() bool        { return debugMode.Load() }
 func IsTerminal() bool {
 	return isatty.IsTerminal(os.Stdout.Fd()) || isatty.IsCygwinTerminal(os.Stdout.Fd())
 }
+
 func IsStdinTerminal() bool {
 	return isatty.IsTerminal(os.Stdin.Fd()) || isatty.IsCygwinTerminal(os.Stdin.Fd())
 }
+
 func IsStderrTerminal() bool {
 	return isatty.IsTerminal(os.Stderr.Fd()) || isatty.IsCygwinTerminal(os.Stderr.Fd())
 }

internal/cmd/app.go

@@ -6,6 +6,8 @@ import (
 	"os/signal"
 	"syscall"
 
+	"github.com/urfave/cli/v3"
+
 	output "github.com/openstatusHQ/cli/internal/cli"
 	"github.com/openstatusHQ/cli/internal/login"
 	"github.com/openstatusHQ/cli/internal/maintenance"
@@ -16,7 +18,6 @@ import (
 	"github.com/openstatusHQ/cli/internal/statusreport"
 	"github.com/openstatusHQ/cli/internal/terraform"
 	"github.com/openstatusHQ/cli/internal/whoami"
-	"github.com/urfave/cli/v3"
 )
 
 func NewApp() *cli.Command {

internal/config/config_test.go

@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/google/go-cmp/cmp"
+
 	"github.com/openstatusHQ/cli/internal/config"
 )
 
@@ -24,7 +25,7 @@ func Test_ReadConfig(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		if _, err := f.Write([]byte(configFile)); err != nil {
+		if _, err := f.WriteString(configFile); err != nil {
 			t.Fatal(err)
 		}
 		if err := f.Close(); err != nil {
@@ -60,7 +61,7 @@ func Test_ReadConfig(t *testing.T) {
 			t.Fatal(err)
 		}
 
-		if _, err := f.Write([]byte("invalid: yaml: content: [")); err != nil {
+		if _, err := f.WriteString("invalid: yaml: content: ["); err != nil {
 			t.Fatal(err)
 		}
 		if err := f.Close(); err != nil {
@@ -78,12 +79,12 @@ func Test_ReadConfig_NoStatePollution(t *testing.T) {
 	dir := t.TempDir()
 
 	file1 := filepath.Join(dir, "config1.yaml")
-	if err := os.WriteFile(file1, []byte("tests:\n  ids:\n    - 1\n    - 2\n    - 3\n"), 0600); err != nil {
+	if err := os.WriteFile(file1, []byte("tests:\n  ids:\n    - 1\n    - 2\n    - 3\n"), 0o600); err != nil {
 		t.Fatal(err)
 	}
 
 	file2 := filepath.Join(dir, "config2.yaml")
-	if err := os.WriteFile(file2, []byte("tests:\n  ids:\n    - 4\n    - 5\n    - 6\n"), 0600); err != nil {
+	if err := os.WriteFile(file2, []byte("tests:\n  ids:\n    - 4\n    - 5\n    - 6\n"), 0o600); err != nil {
 		t.Fatal(err)
 	}
 

internal/config/lock.go

@@ -17,17 +17,15 @@ type Lock struct {
 type MonitorsLock map[string]Lock
 
 func ReadLockFile(filename string) (MonitorsLock, error) {
-
 	var out MonitorsLock
 	if _, err := os.Stat(filename); errors.Is(err, os.ErrNotExist) {
 		return MonitorsLock{}, nil
 	}
 
 	file := file.Provider(filename)
-	var k = koanf.New(".")
+	k := koanf.New(".")
 
 	err := k.Load(file, yaml.Parser())
-
 	if err != nil {
 		return nil, err
 	}
@@ -41,5 +39,4 @@ func ReadLockFile(filename string) (MonitorsLock, error) {
 	}
 
 	return out, nil
-
 }