Skip to content

[PROPOSED] styles framework - change behavior for unset REQUIRED settings from error to warning #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kswanson33 wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[PROPOSED] styles framework - change behavior for unset REQUIRED settings from error to warning #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8265fc
Update version.txt
jbwilson8 Apr 21, 2023
667857d
change behavior for unset REQUIRED settings from error to warning
kswanson33 Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion styles/framework/settings/_init.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ $FRAMEWORK_USED_SETTINGS: ();
@if $default != enum('Object:::NONE') {
@return $default;
}
@return error(enum('Error:::INDEX_ERROR'), "Unknown setting `#{$name}`.");

@warn "Unknown setting `#{$name}`.";
@return "UNSET";
}

@function settings_not_null($name, $default: enum('Object:::NONE')) {
Expand Down
2 changes: 1 addition & 1 deletion version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
hysterical.herbology v1.126.0
iconic.iconology v1.127.0