Skip to content

Add fix for ul overflowing in snap lab page 245 #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
P-Gill97 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add fix for ul overflowing in snap lab page 245 #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

- Add margins to numbered lists in `hs-physics` worked examples and snap labs (CORE-1789)
- Fix list markers inside labeled-item procedure lists overflowing Snap Lab borders in `hs-physics`: add `SnapLabLabeledItemLists` targeting `ul[data-labeled-item="true"] li` context


## [v2.19.0] - 2026-04-15
Expand Down
10 changes: 10 additions & 0 deletions styles/books/hs-physics/book.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,5 +339,15 @@ $ChapterIntroType: fullWidth;

@include use("SnapLabLists", "carnival:::NotesListsShape");

@include add_settings((
SnapLabLabeledItemLists: (
_selectors: ('.snap-lab .os-note-body ul[data-labeled-item="true"] li'),
'FirstLevelUnorderedList:::margin-left': h-spacing(4),
'FirstLevelOrderedList:::margin-left': h-spacing(4),
),
));

@include use("SnapLabLabeledItemLists", "carnival:::NotesListsShape");

// EOB
@include use('Index', 'carnival:::IndexShape');
148 changes: 148 additions & 0 deletions styles/output/hs-physics-pdf.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4844,6 +4844,154 @@ h4.os-subtitle + .os-figure:not(.has-splash) > figure {
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ul:not([data-labeled-item=true], .os-chapter-objectives) {
margin-left: 32px;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ul {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ol {
margin-left: 32px;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ol > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > ol > li > ul {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) {
margin-left: 32px;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ul {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ul > li > ul {
padding-left: 24px;
list-style-type: none;
position: relative;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ul > li > ul > li::before {
font-size: 6px;
content: '▪';
display: inline-block;
position: absolute;
left: 8px;
vertical-align: middle;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ul > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ol > li > ul {
padding-left: 24px;
list-style-type: none;
position: relative;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ol > li > ul > li::before {
font-size: 6px;
content: '▪';
display: inline-block;
position: absolute;
left: 8px;
vertical-align: middle;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ul:not([data-labeled-item=true], .os-chapter-objectives) > li > ol > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol {
margin-left: 32px;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ul {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ul > li > ul {
padding-left: 24px;
list-style-type: none;
position: relative;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ul > li > ul > li::before {
font-size: 6px;
content: '▪';
display: inline-block;
position: absolute;
left: 8px;
vertical-align: middle;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ul > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ol > li > ul {
padding-left: 24px;
list-style-type: none;
position: relative;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ol > li > ul > li::before {
font-size: 6px;
content: '▪';
display: inline-block;
position: absolute;
left: 8px;
vertical-align: middle;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > ol > li > ol > li > ol {
margin-left: 24px;
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > :last-child ul {
margin-bottom: 0;
}

.snap-lab .os-note-body ul[data-labeled-item=true] li > div > :last-child ol {
margin-bottom: 0;
}

.os-index-container {
column-count: 3;
column-gap: 32px;
Expand Down
Loading