Fix radio field crash with nested option strings#12345
Merged
tyrasd merged 1 commit intoMay 18, 2026
Merged
Conversation
Contributor
Author
|
Yay, issue |
Collaborator
|
This will not happen anymore after ideditor/schema-builder#281, right? |
Member
No, this fix is still relevant also when we have pre-resolved strings: If a
|
tyrasd
approved these changes
May 18, 2026
tyrasd
added a commit
to ideditor/schema-builder
that referenced
this pull request
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a
radiofield usesstringsCrossReferenceto reference another field whose option strings are structured as{ title, description }objects (rather than flat strings), rendering the field throws:This happens because
tInforeturns the raw{ title, description }object intexts, andt.appendthen callsselection.call(object)— but D3'sselection.call()expects a function.The
combofield already handles this correctly via itsgetLabelIdhelper, which checks for a.titlesub-key first. Theradiofield was missing equivalent logic.This issue was exposed by openstreetmap/id-tagging-schema#2268, which changes the
parking_entrancefield from typecomboto typeradio. Theparkingfield it references viastringsCrossReferenceuses nested{ title, description }option strings.