render diameter when a feature is selected

[k-yle]

If a node has a tag like diameter or radius, iD will now render a circle when you select the node.

• As per the wiki, spaces are allowed between the number and the unit.
• These tags are supported: diameter, diameter_crown, hole:diameter, radius, crown_radius, and seamark:anchor_berth:radius.
• Many different units of measurement are supported, including a combination of feet and inches
• The default unit is m for all tags except diameter, where the default unit is mm and seamark:anchor_berth:radius where the unit is defined by a separate tag (seamark:anchor_berth:units)

---

does not exactly fix #9189, but solves the problem with an alternative solution

[tordans]

I really like this idea. We are using diameter on trees a lot in Neukölln to render a more realistic Map like https://strassenraumkarte.osm-berlin.org/?map=micromap#19/52.47378/13.43892 so that will help at lot to get a feel for this value.

[tyrasd]

Regarding the concrete styling: I think the red-ish color is a little bit distracting in this context. It reminiscent of the color iD uses for buildings, or could be interpreted as an error even.

What about going with a neutral styling similar to the viewport cones?

g.point .radius,
g.vertex .radius {
    fill: #333;
    fill-opacity: 0.6;
    stroke: #fff;
    stroke-width: 0.5px;
    stroke-opacity: 0.75;
}
.fill-wireframe .radius {
    fill: none;
}

[k-yle]

styling also changed per suggestions above:

[matkoniecz]

@k-yle

This branch has conflicts that must be resolved

[k-yle]

@matkoniecz almost all my PRs will have that label, because editing the CHANGELOG file will create conflicts if a different PR is merged first

[matkoniecz]

natural=tree
diameter=2m
diameter_crown=10m

this will show only the first one

maybe both can be shown?

[k-yle]

maybe both can be shown?

possibly, but the diameter of a tree is usually impossible to see from aerial imagery, right?

so maybe we should only show 1 tag, and prioritise diameter_crown over diameter ?

[matkoniecz]

possibly, but the diameter of a tree is usually impossible to see from aerial imagery, right?

I thought mostly that it would

• look pretty
• be less confusing when some trees have diameter and show this, while other also have diameter_crown and show something else instead
• be used to spot blatantly invalid data

[k-yle]

conclusion:

• we should render multiple rings if there are multiple radius-like tags on the same node
• we should also render $\frac{\text{circumference}}{2\pi}$

that means there could be up to 3 circles rendered for a single tree, diameter, diameter_crown, circumference

there are 13337 nodes with both diameter and $\frac{\text{circumference}}{2\pi}$, which should ideally be consistent