Add fee, payment_multi_fee, and charge_fee fields to Golf Course, Bowling Alley, Ice Rink, and Swimming Pool presets#2131
Conversation
|
it seems that something went wrong with your branches as "Add min_age to escape room and trampoline park moreFields" is also included maybe it will not cause issues as it will be likely merges soon, but each PR should have own branch diverging from upstream |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
074d113 to
bef7146
Compare
Fixed. |
Also, from quick look at code I think that for example charge_fee should be at most in |
Description, Motivation & Context
Fees exist for golf courses, bowling alleys, ice rinks and swimming pools but there's no current field for it. Added fees and payment_multi_fee and charge_fee. Opted for payment_multi_fee instead of payment_multi since it only shows when fee ≠ no (more appropriate). Similarly, changed ice_rink to use payment_multi_fee since some ice rinks are free so it should only show if there's a fee.
Related issues
None
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/fee
https://taginfo.openstreetmap.org/keys/charge
https://taginfo.openstreetmap.org/keys/payment
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.