Skip to content

Add fee, payment_multi_fee, and charge_fee fields to Golf Course, Bowling Alley, Ice Rink, and Swimming Pool presets#2131

Open
ivanfang-dev wants to merge 1 commit into
openstreetmap:mainfrom
ivanfang-dev:add-fee-leisure-venues
Open

Add fee, payment_multi_fee, and charge_fee fields to Golf Course, Bowling Alley, Ice Rink, and Swimming Pool presets#2131
ivanfang-dev wants to merge 1 commit into
openstreetmap:mainfrom
ivanfang-dev:add-fee-leisure-venues

Conversation

@ivanfang-dev
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Fees exist for golf courses, bowling alleys, ice rinks and swimming pools but there's no current field for it. Added fees and payment_multi_fee and charge_fee. Opted for payment_multi_fee instead of payment_multi since it only shows when fee ≠ no (more appropriate). Similarly, changed ice_rink to use payment_multi_fee since some ice rinks are free so it should only show if there's a fee.

Related issues

None

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:
https://taginfo.openstreetmap.org/keys/fee
https://taginfo.openstreetmap.org/keys/charge
https://taginfo.openstreetmap.org/keys/payment

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@ivanfang-dev ivanfang-dev changed the title Add fee leisure venues Add fee, payment_multi_fee, and charge_fee fields to Golf Course, Bowling Alley, Ice Rink, and Swimming Pool presets Mar 31, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Mar 31, 2026

it seems that something went wrong with your branches as "Add min_age to escape room and trampoline park moreFields" is also included

maybe it will not cause issues as it will be likely merges soon, but each PR should have own branch diverging from upstream

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@matkoniecz matkoniecz added the add-field add existing field to more entries, for field creation see new-field label Mar 31, 2026
@ivanfang-dev ivanfang-dev force-pushed the add-fee-leisure-venues branch from 074d113 to bef7146 Compare April 1, 2026 03:48
@ivanfang-dev
Copy link
Copy Markdown
Contributor Author

it seems that something went wrong with your branches as "Add min_age to escape room and trampoline park moreFields" is also included

maybe it will not cause issues as it will be likely merges soon, but each PR should have own branch diverging from upstream

Fixed.

@matkoniecz
Copy link
Copy Markdown
Collaborator

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Also, from quick look at code I think that for example charge_fee should be at most in moreFields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add-field add existing field to more entries, for field creation see new-field

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants