Skip to content

Improve opening_hours placeholder clarity#2140

Open
eeshm wants to merge 1 commit into
openstreetmap:mainfrom
eeshm:chore/opening-hours-placeholder-example
Open

Improve opening_hours placeholder clarity#2140
eeshm wants to merge 1 commit into
openstreetmap:mainfrom
eeshm:chore/opening-hours-placeholder-example

Conversation

@eeshm
Copy link
Copy Markdown

@eeshm eeshm commented Mar 31, 2026

Description, Motivation & Context

Replaces the opening_hours field placeholder from Unknown to Mo-Fr 09:00-18:00 in data/fields/opening_hours.json.

  • opening_hours uses a structured syntax, so a concrete example is clearer and helps mappers enter valid values.
  • Scope is intentionally small: text-only change, no logic/UI behavior changes.

Related issues

  • none

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@eeshm
Copy link
Copy Markdown
Author

eeshm commented Mar 31, 2026

Test-Documentation

Preview links & Sidebar Screenshots

  • Link
  • Verified that the Hours field now shows placeholder Mo-Fr 09:00-18:00.
image

Search

  • N/A (no preset/search terms changed)

Info-i

  • N/A (no info-i content changed)

Wording

  • American English
  • name, aliases (if present) use Title Case (N/A - unchanged)
  • terms (if present) use lower case, sorted A-Z (N/A - unchanged)

"type": "combo",
"label": "Hours",
"placeholder": "Unknown",
"placeholder": "Mo-Fr 09:00-18:00",
Copy link
Copy Markdown
Contributor

@1ec5 1ec5 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyrasd, I think iD’s taginfo-based suggestions used to override this placeholder, but I no longer see them even though they appear in the dropdown menu. Instead it says “Unknown…” based on the placeholder property. Could it be fallout from openstreetmap/iD#11794? This PR would address this one instance, but others like service_times=* would still be affected.

@matkoniecz
Copy link
Copy Markdown
Collaborator

matkoniecz commented Apr 1, 2026

Currently placeholders are a wild mix

I see example values, explanations, marking values as unknown if unset.

Not sure which is best. Do we have documented anywhere for what placeholders are supposed to be?
I guess that optimal form will depend on case but it seem a bit too much.

screen-2026-04-01-06-22-23

@eeshm
Copy link
Copy Markdown
Author

eeshm commented Apr 1, 2026

thanks, this makes sense.

I agree this PR likely addresses only one instance. My goal here is a narrow improvement to opening_hours, where Unknown is less helpful than a valid example for a very common field.

I also agree there’s a broader consistency question for placeholders (example vs explanation vs unknown-state wording), and possibly an iD-side behavior change in how suggestions/placeholder are shown.

If this scope is acceptable, I’d like to keep this PR limited to opening_hours and open a follow-up issue for:

  1. placeholder style guidance in id-tagging-schema
  2. whether iD placeholder/suggestion behavior changed (possibly related to fixes rare tag value auto suggestions (fix #11782) iD#11794)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants