Improve opening_hours placeholder clarity#2140
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar Screenshots
Search
Info-
|
| "type": "combo", | ||
| "label": "Hours", | ||
| "placeholder": "Unknown", | ||
| "placeholder": "Mo-Fr 09:00-18:00", |
There was a problem hiding this comment.
@tyrasd, I think iD’s taginfo-based suggestions used to override this placeholder, but I no longer see them even though they appear in the dropdown menu. Instead it says “Unknown…” based on the placeholder property. Could it be fallout from openstreetmap/iD#11794? This PR would address this one instance, but others like service_times=* would still be affected.
|
thanks, this makes sense. I agree this PR likely addresses only one instance. My goal here is a narrow improvement to opening_hours, where Unknown is less helpful than a valid example for a very common field. I also agree there’s a broader consistency question for placeholders (example vs explanation vs unknown-state wording), and possibly an iD-side behavior change in how suggestions/placeholder are shown. If this scope is acceptable, I’d like to keep this PR limited to opening_hours and open a follow-up issue for:
|


Description, Motivation & Context
Replaces the
opening_hoursfield placeholder fromUnknowntoMo-Fr 09:00-18:00indata/fields/opening_hours.json.opening_hoursuses a structured syntax, so a concrete example is clearer and helps mappers enter valid values.Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.