Skip to content

Icon for building=civic and building=public#2147

Open
matkoniecz wants to merge 1 commit into
openstreetmap:mainfrom
matkoniecz:civic_building
Open

Icon for building=civic and building=public#2147
matkoniecz wants to merge 1 commit into
openstreetmap:mainfrom
matkoniecz:civic_building

Conversation

@matkoniecz
Copy link
Copy Markdown
Collaborator

tries to find icon focusing and architectural style, not the current use (like icon with flag next to an office building)

Description, Motivation & Context

see #41

Related issues

fixes part of #41

Links and data

Relevant OSM Wiki links:

https://wiki.openstreetmap.org/wiki/Tag:building%3Dcivic

https://wiki.openstreetmap.org/wiki/Tag:building%3Dpublic

Relevant tag usage stats:

none relevant

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

Comment thread data/fields/building.json
},
"icons": {
"public": "fas-institution",
"civic": "fas-institution"
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that PR get accepted including that part we should list more icons here

see also ideditor/schema-builder#275 - referencing would be nice here

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz
Copy link
Copy Markdown
Collaborator Author

@matkoniecz matkoniecz marked this pull request as ready for review April 1, 2026 19:04
@matkoniecz
Copy link
Copy Markdown
Collaborator Author

screen-2026-04-01-21-06-58 screen-2026-04-01-21-06-31

@matkoniecz matkoniecz changed the title Icon for building=civic and building=instiution Icon for building=civic and building=public Apr 1, 2026
fixes part of openstreetmap#41

tries to find icon focusing and architectural style, not the current use (like icon with flag next to an office building)
@k-yle
Copy link
Copy Markdown
Collaborator

k-yle commented Apr 22, 2026

if we decide to add icons for these building types, i feel like we should add all of them at once? (if there is a suitable icon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants