Introduce private swimming pool preset; modify general preset

[tordans]

See #2221

Notes:

The general presets has the same name. It is not the public preset, because it does not set any access; And I don't think our "unspecified" terminology applies here, it is just the preset that is not the "private" one.

However, I move the access field to the top to signal it is important. And move lit and length to more fields because I just don't see them on the same level of importance as the other fields.

The private preset is simplified by design. But given it is also used for private hotel pools some of the fields are still relevant.

[github-actions]

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

[tordans]

Testing

Private

https://pr-2224--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=20.00/34.99138/33.97519&disable_features=boundaries&background=Mapbox&id=w1506892383

• 
• 
• 
• 
• 

Public

• 

[andrewharvey]

I worry this may be misused as private as in it has privacy, or private as in it's privately operated (as opposed to publicly/government operated) or privately owned (as opposed to public/government owned), and not what access=private means which is private access (with individual permission) only.

A hotel/resort pool would usually be access=customers, a private owned/operated commercial swimming pool open to the general public would be access=yes.

At least if a mapper has to select from the Allowed Access field they can see that the field is for "allowed access" and see all the other access values when making the selection, and see the tag hint text when setting it.

[andrewharvey]

However, I move the access field to the top to signal it is important. And move lit and length to more fields because I just don't see them on the same level of importance as the other fields.

I agree with this.

[tordans]

@andrewharvey yes, we had the same issue with the "private driveway" PR.

Do you see a way to resolve this with the tools (manly icon and title) we have?

[andrewharvey]

In my experience the biggest issue is residential pools that lack access=private, so a preset "Residential Swimming Pool" would be best, though the problem is we don't have a tag to say it's residential, apart from leisure=swimming_pool access=private within a landuse=residential area.

Perhaps the change to move access higher in the fields list would suffice?

I'm not sure...

[tordans]

We could make it a bit verbose in the preset title, could we note?

• General preset:

  Swimming Pool

• Additional preset:

  Swimming Pool (private access)

The same would work for #2225

• General preset:

  Driveway

• Additional preset:

  Driveway (private access)

---

Update: I just made this change so we can look at the result in the preview

[andrewharvey]

Swimming Pool (private access)

I think this is clearer and less ambiguous than just "Private Swimming Pool".

Additional presets which specify the preset field values are good where there is a common term that distinguishes them, for example highway=service as "Service Road" benefits from the presets "Driveway" for highway=service + service=driveway and "Parking Aisle" for `service=parking_aisle".

In the same way that swimming_pool=swimming/lap could be "Lap Pool" and `swimming_pool=wave_pool" could be "Wave Pool", but once you start adding "(private access)" variants you open the door to many variations, e.g "Outdoor Lap Pool", "Indoor Lap Pool", "Outdoor Lap Pool (private access)", "Indoor Lap Pool (private access)", etc.