You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Easier to see, and removes the need for querying taginfo statistics for this field.
Note: The dog_yes.json field is only used in the amenity=dog_toilet and leisure=dog_park presets, where the yes/no/designated/outside values don't make much sense. That's why the combo field already disabled auto suggestions and custom values, and changing to a radio field seems to make sense. (see example 2 in the test documentation below)
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
🍱 Your pull request preview is ready.
If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.
## Test-Documentation
### Preview links & Sidebar Screenshots
<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
Add relevant **screenshots** of the sidebar of those examples. -->
<!-- FYI: What we will check:
- Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
- Are the fields well-structured and have good labels.
- Do the dropdowns (etc.) work well and show helpful data. -->
### Search
<!-- **Test the search** of your preset and share relevant **screenshots** here.
- Test the preset name as search terms.
- Also test the preset terms and aliases as search terms (if present). -->
### Info-`i`
<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
The info needs to help mappers understand the preset and when to use it.
[Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
-->
### Wording
- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->
Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.
FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Motivation & Context
Easier to see, and removes the need for querying taginfo statistics for this field.
Note: The
dog_yes.jsonfield is only used in theamenity=dog_toiletandleisure=dog_parkpresets, where theyes/no/designated/outsidevalues don't make much sense. That's why the combo field already disabled auto suggestions and custom values, and changing to a radio field seems to make sense. (see example 2 in the test documentation below)Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.