Skip to content

Change aerialway:access fields from combo to radio#2266

Merged
matkoniecz merged 3 commits into
openstreetmap:mainfrom
FloEdelmann:aerialway-access-radio
May 19, 2026
Merged

Change aerialway:access fields from combo to radio#2266
matkoniecz merged 3 commits into
openstreetmap:mainfrom
FloEdelmann:aerialway-access-radio

Conversation

@FloEdelmann
Copy link
Copy Markdown
Contributor

@FloEdelmann FloEdelmann commented May 15, 2026

Description, Motivation & Context

Easier to see, and removes the need for querying taginfo statistics for this field.

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@FloEdelmann

This comment was marked as outdated.

@matkoniecz
Copy link
Copy Markdown
Collaborator

BTW, I am quite unhappy with label for this field but have no better ideas for now

@matkoniecz
Copy link
Copy Markdown
Collaborator

though wiki at https://wiki.openstreetmap.org/wiki/Key:aerialway claims that no is valid

Copy link
Copy Markdown
Collaborator

@matkoniecz matkoniecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matkoniecz matkoniecz added the feedback-required Further information is requested. Issue/pull request may be closed if it will not be provided. label May 16, 2026
@FloEdelmann
Copy link
Copy Markdown
Contributor Author

FloEdelmann commented May 17, 2026

You're right, good catch! Since the value is indeed documented (I had missed that) and used and the comments to your notes reveal that their use is intentional, I think the no value needs to be added to the field first. I have opened #2273 for that.

While that PR is reviewed, I'll convert this one to a draft, so it isn't accidentally merged.

Before merging, I'd also include the same conversion (combo → radio) for the aerialway:summer:access field as well, as it works exactly the same and has the same values. For that field I just happened to notice the missing no value, so I didn't change it (see #2049 (comment)).

@FloEdelmann FloEdelmann marked this pull request as draft May 17, 2026 11:41
@matkoniecz matkoniecz removed the feedback-required Further information is requested. Issue/pull request may be closed if it will not be provided. label May 18, 2026
@matkoniecz
Copy link
Copy Markdown
Collaborator

@FloEdelmann can you merge in master and retest it

@FloEdelmann FloEdelmann changed the title Change aerialway:access field from combo to radio Change aerialway:access fields from combo to radio May 18, 2026
@FloEdelmann FloEdelmann marked this pull request as ready for review May 18, 2026 09:32
@FloEdelmann
Copy link
Copy Markdown
Contributor Author

Test-Documentation

Preview links & Sidebar Screenshots

aerialway=station with aerialway:access=exit and aerialway:summer:access=neither: https://pr-2266--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=18.00/47.73427/11.49539&background=Bing&id=n12691507591

grafik

aerialway=station without aerialway:access or aerialway:summer:access: https://pr-2266--ideditor-presets-preview.netlify.app/id/dist/#locale=en&map=19.10/47.67604/11.55385&background=Bing&id=w110343515

grafik

@matkoniecz matkoniecz merged commit 20d8413 into openstreetmap:main May 19, 2026
5 checks passed
@FloEdelmann FloEdelmann deleted the aerialway-access-radio branch May 19, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants