Skip to content

Change parking_entrance field from combo to radio#2268

Draft
FloEdelmann wants to merge 1 commit into
openstreetmap:mainfrom
FloEdelmann:parking-entrance-radio
Draft

Change parking_entrance field from combo to radio#2268
FloEdelmann wants to merge 1 commit into
openstreetmap:mainfrom
FloEdelmann:parking-entrance-radio

Conversation

@FloEdelmann
Copy link
Copy Markdown
Contributor

Description, Motivation & Context

Easier to see, and removes the need for querying taginfo statistics for this field.

Note: The field previously allowed custom values via customValues: true. But according to this Overpass query I could find all values worldwide that are not supported as options: 12×exit, 7×car_repair, 7×staircase, 3×roof, 2×entrance, 1×vehicle, 1×yes
Out of 125 946 amenity=parking_entrance+parking=* combinations (according to taginfo), I think it's fine to ignore those few cases.

Related issues

Links and data

Relevant OSM Wiki links:

Relevant tag usage stats:

Checklist and Test-Documentation Template

Read on to get your PR merged faster…

Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.

This is how it works:

  1. After you submit your PR, the system will create a preview and comment on your PR:

    🍱 Your pull request preview is ready.
    If this is your first contribution to this project, the preview will not happen right away but requires a click from one of the project members. We will do this ASAP.

  2. Once the preview is ready, use it to test your changes.

  3. Now copy the snippet below into a new comment and fill out the blanks.

  4. Now your PR is ready to be reviewed.

## Test-Documentation

### Preview links & Sidebar Screenshots

<!-- Use the preview to find examples, select the feature in question and **copy this link here**.
     Find examples of nodes/areas. Find examples with a lot of tags or very few tags. – Whatever helps to test this thoroughly.
     Add relevant **screenshots** of the sidebar of those examples. -->

<!-- FYI: What we will check:
     - Is the [icon](https://github.com/ideditor/schema-builder/blob/main/ICONS.md) well chosen.
     - Are the fields well-structured and have good labels.
     - Do the dropdowns (etc.) work well and show helpful data. -->

### Search

<!-- **Test the search** of your preset and share relevant **screenshots** here.
     - Test the preset name as search terms.
     - Also test the preset terms and aliases as search terms (if present). -->

### Info-`i`

<!-- **Test the info-i** for your fields and preset and share relevant **screenshots** here.
     The info needs to help mappers understand the preset and when to use it.
     [Learn more…](https://github.com/openstreetmap/id-tagging-schema/blob/main/CONTRIBUTING.md#info-i)
 -->

### Wording

- [ ] American English
- [ ] `name`, `aliases` (if present) use Title Case
- [ ] `terms` (if present) use lower case, sorted A-Z
<!-- Learn more in https://github.com/openstreetmap/id-tagging-schema/blob/main/GUIDELINES.md#2-design-the-preset -->

@github-actions
Copy link
Copy Markdown

🍱 Your pull request preview is ready

Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone.

FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes.

@FloEdelmann FloEdelmann marked this pull request as draft May 15, 2026 17:19
@FloEdelmann
Copy link
Copy Markdown
Contributor Author

FloEdelmann commented May 15, 2026

Test-Documentation

Preview links & Sidebar Screenshots

Error happens in for all of those elements and also in Chrome, where there is a bit more info:

grafik

Clearly there is something wrong here. I'll investigate.

@FloEdelmann
Copy link
Copy Markdown
Contributor Author

iD doesn't support radio fields with stringsCrossReference whose option strings are structured as { title, description } objects (rather than flat strings) yet.

@matkoniecz
Copy link
Copy Markdown
Collaborator

this can potentially wait for ideditor/schema-builder#281

especially as there is chance for release happening soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants