Change parking_entrance field from combo to radio#2268
Conversation
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
Test-DocumentationPreview links & Sidebar Screenshots
Error happens in for all of those elements and also in Chrome, where there is a bit more info:
Clearly there is something wrong here. I'll investigate. |
|
iD doesn't support radio fields with |
|
this can potentially wait for ideditor/schema-builder#281 especially as there is chance for release happening soon |



Description, Motivation & Context
Easier to see, and removes the need for querying taginfo statistics for this field.
Note: The field previously allowed custom values via
customValues: true. But according to this Overpass query I could find all values worldwide that are not supported as options: 12×exit, 7×car_repair, 7×staircase, 3×roof, 2×entrance, 1×vehicle, 1×yesOut of 125 946
amenity=parking_entrance+parking=*combinations (according to taginfo), I think it's fine to ignore those few cases.Related issues
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.