gemini suggestions

mkleene · mkleene · commit f94c1dfab2f3 · 2025-07-03T14:42:43.000+02:00
diff --git a/sdk/src/main/java/io/opentdf/platform/sdk/Autoconfigure.java b/sdk/src/main/java/io/opentdf/platform/sdk/Autoconfigure.java
@@ -254,9 +254,9 @@ String name() {
                 throw new RuntimeException("invalid attributeInstance");
             }
             try {
-                return URLDecoder.decode(matcher.group(1), StandardCharsets.UTF_8);
-            } catch (IllegalArgumentException e) {
-                throw new RuntimeException("invalid attributeInstance", e);
+                return URLDecoder.decode(matcher.group(1), StandardCharsets.UTF_8.name());
+            }  catch (UnsupportedEncodingException e) {
+                throw new RuntimeException("illegal attribute instance", e);
             }
         }
     }
@@ -867,7 +867,7 @@ static Autoconfigure.Granter createGranter(SDK.Services services, Config.TDFConf
         return granter;
     }
 
-    private static Granter getGranter(KASKeyCache keyCache, List<GetAttributeValuesByFqnsResponse.AttributeAndValue> values) {
+    private static Granter getGranter(@Nullable KASKeyCache keyCache, List<GetAttributeValuesByFqnsResponse.AttributeAndValue> values) {
         List<AttributeValueFQN> attributeValues = values.stream()
                 .map(GetAttributeValuesByFqnsResponse.AttributeAndValue::getValue)
                 .map(Value::getFqn)

Original file line number	Diff line number	Diff line change
`@@ -254,9 +254,9 @@ String name() {`
`254`	`254`	`throw new RuntimeException("invalid attributeInstance");`
`255`	`255`	`}`
`256`	`256`	`try {`
`257`		`- return URLDecoder.decode(matcher.group(1), StandardCharsets.UTF_8);`
`258`		`- } catch (IllegalArgumentException e) {`
`259`		`- throw new RuntimeException("invalid attributeInstance", e);`
	`257`	`+ return URLDecoder.decode(matcher.group(1), StandardCharsets.UTF_8.name());`
	`258`	`+ } catch (UnsupportedEncodingException e) {`
	`259`	`+ throw new RuntimeException("illegal attribute instance", e);`
`260`	`260`	`}`
`261`	`261`	`}`
`262`	`262`	`}`
`@@ -867,7 +867,7 @@ static Autoconfigure.Granter createGranter(SDK.Services services, Config.TDFConf`
`867`	`867`	`return granter;`
`868`	`868`	`}`
`869`	`869`
`870`		`- private static Granter getGranter(KASKeyCache keyCache, List<GetAttributeValuesByFqnsResponse.AttributeAndValue> values) {`
	`870`	`+ private static Granter getGranter(@Nullable KASKeyCache keyCache, List<GetAttributeValuesByFqnsResponse.AttributeAndValue> values) {`
`871`	`871`	`List<AttributeValueFQN> attributeValues = values.stream()`
`872`	`872`	`.map(GetAttributeValuesByFqnsResponse.AttributeAndValue::getValue)`
`873`	`873`	`.map(Value::getFqn)`