chore: Bump and rename sslcontext-kicktart to ayza#291
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Hakky54, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the project's dependencies to reflect a recent renaming of the sslcontext-kickstart library to ayza and bumps its version to 10.0.0. This ensures the project remains compatible with the latest version of the library under its new name.
Highlights
- Library Renaming: The
sslcontext-kickstartlibrary and its related modules (sslcontext-kickstart-for-pem,sslcontext-kickstart-for-netty) have been renamed toayzaand its corresponding modules (ayza-for-pem,ayza-for-netty). - Version Update: The
ayzalibrary has been updated to version10.0.0.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the sslcontext-kickstart dependency to its new name and version, ayza 10.0.0. The changes in the pom.xml files correctly reflect this update. However, a critical part of this migration was missed: the Java source code that uses this library has not been updated. The package name for ayza has changed from nl.altindag.ssl to io.github.hakky54.ssl, which will lead to compilation failures. I've added a specific comment on how to resolve this.
Signed-off-by: Hakky54 <hakangoudberg@hotmail.com>
jentfoo
changed the title
jentfoo
left a comment
jentfoo
left a comment
There was a problem hiding this comment.
@Hakky54 I see you're a first time contributor. I also see you have correctly signed your commit, can you confirm this is an acknowledgment of our CLA: https://github.com/opentdf/java-sdk/blob/main/CONTRIBUTING.md#what-does-signing-off-mean
I see that I didn't created the PR name correctly, thank you for adjusting it.
Yes, that is fine. I acknowledge the CLA. Do I need to do something else from my side or do you think the PR is fine? |
Thank you for the contribution! I'm going to close this in favor of #293 since we have to do a little more dependency management to make all of our checks pass. |
|
@Hakky54 I hope you don't mind me closing this, I just figured you wouldn't want to worry about the details of our project. Thank you so much for the pull request! |
|
sure, thats fine! Thank you for cherry picking my changes |
also make sure that we have a dependency on `bcprov-jdk18on` since we use this provider in our code takes over this pull from the library author #291
3 participants
The library has been renamed from sslcontext-kickstart to ayza. The latest version is 10.0.0
Sorry for the inconvenience