[Fix] IAM: Add XuserType and XuserID to users.CreateOpts#938
Open
TobiWo wants to merge 1 commit into
Open
Conversation
Author
|
Hi @anton-sidelnikov , this PR needs review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Add
XuserTypeandXuserIDfields toCreateOptsinopenstack/identity/v3.0/users/CreateUser.go.The OTC IAM API (
POST /v3.0/OS-USER/users) acceptsxuser_typeandxuser_idin the request body. Both fields are already present in theUserresponse struct and inUpdateAdminOpts, but missing fromCreateOpts. This forces callers to issue a secondModifyUserAdmincall after creation to set the external identity fields, which is non-atomic.With this change, callers can set
XuserTypeandXuserIDin a single create call.Which issue this PR fixes
fixes #937
Special notes for your reviewer
omitemptyso the request body is unchanged for existingcallers that do not set these fields -> no breaking change.
UpdateAdminOpts(xuser_type,xuser_id).Note
A follow-up PR will be created for the terraform-provider itself so that resource
opentelekomcloud_identity_user_v3will make use of the updated struct.