Skip to content

Commit 1cad8cf

Browse files
authored
fix(cbr): docs fixed (#620)
fix(cbr): docs fixed Reviewed-by: Anton Sidelnikov Reviewed-by: Dmitrii Sabelnikov
1 parent 5eedf3c commit 1cad8cf

7 files changed

Lines changed: 17 additions & 13 deletions

File tree

examples/cbr/delete_policy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020

2121

2222
policy = '52606d56-d129-44d1-85da-1cc7b837942e'
23-
policy = conn.cbr.find_policy(name_or_id=policy)
23+
policy = conn.cbr.find_policy(policy_id=policy)
2424
conn.cbr.delete_policy(policy=policy)

examples/cbr/find_policy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020

2121

2222
policy = 'name_or_id'
23-
policy = conn.cbr.find_policy(name_or_id=policy)
23+
policy = conn.cbr.find_policy(policy_id=policy)
2424
print(policy)

examples/cbr/update_policy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@
4040
}
4141

4242
policy = 'name_or_id'
43-
policy = conn.cbr.find_policy(name_or_id=policy)
43+
policy = conn.cbr.find_policy(policy_id=policy)
4444
policy = conn.cbr.update_policy(policy=policy, **attrs)
4545
print(policy)

otcextensions/osclient/cbr/v3/policy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def take_action(self, parsed_args):
138138
client = self.app.client_manager.cbr
139139

140140
obj = client.find_policy(
141-
name_or_id=parsed_args.policy,
141+
policy_id=parsed_args.policy,
142142
ignore_missing=False
143143
)
144144

@@ -486,7 +486,7 @@ def take_action(self, parsed_args):
486486

487487
client = self.app.client_manager.cbr
488488
policy = client.find_policy(
489-
name_or_id=parsed_args.policy,
489+
policy_id=parsed_args.policy,
490490
ignore_missing=False
491491
)
492492

@@ -525,7 +525,7 @@ def take_action(self, parsed_args):
525525
client = self.app.client_manager.cbr
526526

527527
policy = client.find_policy(
528-
name_or_id=parsed_args.policy,
528+
policy_id=parsed_args.policy,
529529
ignore_missing=False
530530
)
531531

otcextensions/sdk/cbr/v3/_proxy.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,10 +185,10 @@ def get_policy(self, policy):
185185
_policy.Policy, policy
186186
)
187187

188-
def find_policy(self, name_or_id, ignore_missing=True):
189-
"""Find a single CBR policy by name or ID
188+
def find_policy(self, policy_id, ignore_missing=True):
189+
"""Find a single CBR policy by ID
190190
191-
:param name_or_id: The name or ID of a policy
191+
:param policy_id: The ID of a policy
192192
:param bool ignore_missing: When set to ``False``
193193
:class:`~openstack.exceptions.ResourceNotFound` will be raised
194194
when the policy does not exist.
@@ -197,7 +197,7 @@ def find_policy(self, name_or_id, ignore_missing=True):
197197
198198
:returns: a :class:`~otcextensions.sdk.cbr.v3.policy.Policy` instance
199199
"""
200-
return self._find(_policy.Policy, name_or_id,
200+
return self._find(_policy.Policy, policy_id,
201201
ignore_missing=ignore_missing)
202202

203203
def create_policy(self, **attrs):

otcextensions/tests/unit/osclient/cbr/v3/test_policy.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ def test_default(self):
219219
columns, data = self.cmd.take_action(parsed_args)
220220

221221
self.client.find_policy.assert_called_once_with(
222-
name_or_id='policy',
222+
policy_id='policy',
223223
ignore_missing=False,
224224
)
225225

@@ -277,7 +277,7 @@ def test_delete(self):
277277

278278
find_calls = [
279279
mock.call(
280-
name_or_id='p1',
280+
policy_id='p1',
281281
ignore_missing=False),
282282
]
283283

@@ -482,7 +482,7 @@ def test_default(self):
482482
columns, data = self.cmd.take_action(parsed_args)
483483

484484
self.client.find_policy.assert_called_with(
485-
name_or_id='policy_id',
485+
policy_id='policy_id',
486486
ignore_missing=False)
487487

488488
self.client.update_policy.assert_called_once_with(
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
---
2+
fixes:
3+
- |
4+
Fixed variable names and description in CBR policy configuration to ensure clarity and consistency.

0 commit comments

Comments
 (0)