fix(CES): added list method to catch empty lists (#656)

fix(CES): added list method to catch empty lists

Reviewed-by: Anton Sidelnikov

Author: RusselSand

otcextensions/sdk/ces/v1/metric.py

@@ -9,6 +9,7 @@
 # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 # License for the specific language governing permissions and limitations
 # under the License.
+from openstack import exceptions
 from openstack import resource
 
 
@@ -44,3 +45,34 @@ class Metric(resource.Resource):
     namespace = resource.Body("namespace")
     #: Indicates the metric unit
     unit = resource.Body("unit")
+
+    @classmethod
+    def list(
+        cls,
+        session,
+        paginated=True,
+        base_path=None,
+        allow_unknown_params=False,
+        **params
+    ):
+        if base_path is None:
+            base_path = cls.base_path
+        query_params = cls._query_mapping._transpose(params, cls)
+        uri = base_path.format(**params)
+        response = session.get(
+            uri,
+            headers={"Accept": "application/json"},
+            params=query_params,
+        )
+        exceptions.raise_from_response(response)
+        data = response.json()
+        resources = data.get(cls.resources_key) or []
+        for raw in resources:
+            if not isinstance(raw, dict):
+                continue
+            raw.pop("self", None)
+            yield cls.existing(
+                microversion=None,
+                connection=session._get_connection(),
+                **raw,
+            )

otcextensions/tests/functional/sdk/ces/v1/test_metric.py

@@ -0,0 +1,38 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may
+# not use this file except in compliance with the License. You may obtain
+# a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+from openstack import _log
+from otcextensions.tests.functional import base
+
+_logger = _log.setup_logging("openstack")
+
+
+class TestMetric(base.BaseFunctionalTest):
+
+    def test_list(self):
+        metrics = list(self.conn.ces.metrics())
+        self.assertGreater(len(metrics), 0)
+
+    def test_list_with_non_existing_params(self):
+        metrics = list(
+            self.conn.ces.metrics(
+                namespace="SYS.ECS", metric_name="totally_fake_metric_xyz"
+            )
+        )
+        self.assertEqual(len(metrics), 0)
+
+    def test_list_with_existing_metric(self):
+        metrics = list(
+            self.conn.ces.metrics(
+                namespace="SYS.ECS",
+            )
+        )
+        self.assertIsNotNone(metrics)