feat: functional tests for headers and ok codes

Author: RusselSand

docs/conf.py

@@ -9,8 +9,8 @@
 # -- Project information -----------------------------------------------------
 
 project = "SDK"
-copyright = "2026, T Cloud"
-author = "T Cloud"
+copyright = "2026, T Cloud Public"
+author = "T Cloud Public"
 release = "0.1.0"
 
 # -- General configuration ---------------------------------------------------

tests/functional/__init__.py

@@ -0,0 +1,45 @@
+from __future__ import annotations
+
+from collections.abc import Callable
+
+import httpx
+
+from sdk.core.auth import AuthConfig
+from sdk.core.endpoint import CatalogEntry, build_endpoint_locator
+from sdk.core.provider import ProviderClient
+
+
+FAKE_CATALOG = [
+    CatalogEntry(
+        type="vpc",
+        endpoints=[
+            {
+                "interface": "public",
+                "region_id": "eu-de",
+                "url": "https://vpc.eu-de.otc.t-systems.com/v1/test-project-id",
+            },
+        ],
+    ),
+]
+
+
+def make_provider(
+    handler: Callable[[httpx.Request], httpx.Response],
+) -> ProviderClient:
+    cfg = AuthConfig(
+        identity_endpoint="https://iam.eu-de.otc.t-systems.com/v3",
+        access_key="AK_TEST",
+        secret_key="SK_TEST",
+        region="eu-de",
+    )
+    transport = httpx.MockTransport(handler)
+    http_client = httpx.Client(transport=transport)
+    provider = ProviderClient(cfg, http_client=http_client)
+
+    provider.project_id = "test-project-id"
+    provider.token_id = "test-token"
+    provider.endpoint_locator = build_endpoint_locator(
+        FAKE_CATALOG, "eu-de",
+    )
+
+    return provider

tests/functional/conftest.py

@@ -0,0 +1,143 @@
+"""Functional tests for HTTP headers merging.
+
+Verifies that the full pipeline (ProviderClient → ServiceClient →
+HTTP request) correctly merges headers from all layers:
+default, service-level, per-request, and auth.
+
+Uses httpx.MockTransport to capture actual outgoing requests.
+"""
+
+from __future__ import annotations
+
+import httpx
+
+from sdk.core.service_client import ServiceClient
+
+from .conftest import make_provider
+
+
+class TestDefaultHeaders:
+    """Default headers (Accept, User-Agent) are always present."""
+
+    def test_accept_header(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+        client.get("test-path")
+
+        assert "application/json" in captured[0].headers["accept"]
+
+    def test_user_agent_header(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+        client.get("test-path")
+
+        assert "user-agent" in captured[0].headers
+
+    def test_content_type_on_json_body(self):
+        """POST with json body sets Content-Type: application/json."""
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        client.post("vpcs", json={"vpc": {"name": "test"}})
+
+        assert "application/json" in captured[0].headers["content-type"]
+
+
+class TestServiceHeaders:
+    """ServiceClient.extra_headers arrive in the final request."""
+
+    def test_extra_headers_sent(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        client.extra_headers["X-Language"] = "en-us"
+        client.extra_headers["X-Custom-Service"] = "my-value"
+
+        client.get("test-path")
+
+        assert captured[0].headers["x-language"] == "en-us"
+        assert captured[0].headers["x-custom-service"] == "my-value"
+
+
+class TestPerRequestHeaders:
+    """Per-request headers override service-level headers."""
+
+    def test_override_service_header(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+        client.extra_headers["X-Language"] = "en-us"
+
+        client.get("test-path", headers={"X-Language": "de-de"})
+
+        assert captured[0].headers["x-language"] == "de-de"
+
+
+class TestAuthHeaders:
+    """Auth headers are injected into the request."""
+
+    def test_aksk_authorization_present(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+        client.get("test-path")
+
+        assert "authorization" in captured[0].headers
+
+
+class TestAllHeadersCombined:
+    """All header layers work together in a single request."""
+
+    def test_default_service_request_and_auth(self):
+        captured: list[httpx.Request] = []
+
+        def handler(req: httpx.Request) -> httpx.Response:
+            captured.append(req)
+            return httpx.Response(200, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+        client.extra_headers["X-Custom"] = "service-level"
+
+        client.get("test-path", headers={"X-Request-Id": "req-123"})
+
+        req = captured[0]
+        assert "application/json" in captured[0].headers["accept"]
+        assert "user-agent" in req.headers
+        assert req.headers["x-custom"] == "service-level"
+        assert req.headers["x-request-id"] == "req-123"
+        assert "authorization" in req.headers

tests/functional/test_headers.py

@@ -0,0 +1,136 @@
+"""Functional tests for ok_codes error handling.
+
+Verifies that the full pipeline (ProviderClient → ServiceClient →
+HTTP request) correctly raises HttpError when the response status
+code is not in the expected ok_codes list.
+
+Uses httpx.MockTransport to simulate server responses.
+"""
+
+from __future__ import annotations
+
+import httpx
+import pytest
+
+from sdk.core.exceptions import HttpError
+from sdk.core.service_client import ServiceClient
+
+from .conftest import make_provider
+
+
+class TestUnexpectedStatusRaises:
+    """Non-ok status codes must raise HttpError."""
+
+    def test_500_raises(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(500, json={"error": "internal"})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        with pytest.raises(HttpError) as exc_info:
+            client.get("test-path")
+
+        assert exc_info.value.status_code == 500
+
+    def test_404_raises(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(404, json={"error": {"message": "not found"}})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        with pytest.raises(HttpError) as exc_info:
+            client.get("vpcs/nonexistent-id")
+
+        assert exc_info.value.status_code == 404
+
+    def test_403_raises(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(403, json={"error": "forbidden"})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        with pytest.raises(HttpError) as exc_info:
+            client.get("test-path")
+
+        assert exc_info.value.status_code == 403
+
+
+class TestCustomOkCodes:
+    """Custom ok_codes override default behavior."""
+
+    def test_custom_ok_codes_accepted(self):
+        """ok_codes=[204] allows 204 on GET (normally only 200)."""
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(204)
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        resp = client.get("test-path", ok_codes=[204])
+        assert resp.status_code == 204
+
+    def test_custom_ok_codes_rejects_unexpected(self):
+        """ok_codes=[200] rejects 201."""
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(201, json={})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        with pytest.raises(HttpError) as exc_info:
+            client.get("test-path", ok_codes=[200])
+
+        assert exc_info.value.status_code == 201
+
+
+class TestDefaultOkCodesPerMethod:
+    """Each HTTP method has its own default ok_codes."""
+
+    def test_post_accepts_201(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(201, json={"vpc": {}})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        resp = client.post("vpcs", json={"vpc": {}})
+        assert resp.status_code == 201
+
+    def test_delete_accepts_204(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(204)
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        resp = client.delete("vpcs/some-id")
+        assert resp.status_code == 204
+
+    def test_put_accepts_200(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(200, json={"vpc": {}})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        resp = client.put("vpcs/some-id", json={"vpc": {}})
+        assert resp.status_code == 200
+
+
+class TestErrorContainsDebugInfo:
+    """HttpError must contain enough info for debugging."""
+
+    def test_status_code_in_error(self):
+        def handler(req: httpx.Request) -> httpx.Response:
+            return httpx.Response(409, json={"error": "conflict"})
+
+        provider = make_provider(handler)
+        client = ServiceClient(provider, "vpc")
+
+        with pytest.raises(HttpError) as exc_info:
+            client.post("vpcs", json={})
+
+        assert exc_info.value.status_code == 409

tests/functional/test_ok_codes.py

@@ -67,7 +67,7 @@ def test_create_sends_post(self):
         result = vpc.create(client, opts)
 
         client.post.assert_called_once_with(
-            f"v1/{PROJECT_ID}/vpcs",
+            f"vpcs",
             json={"vpc": {"name": "vpc", "cidr": "192.168.0.0/16"}},
         )
         assert result.id == "99d9d709-8478-4b46-9f3f-2206b1023fd3"
@@ -102,7 +102,7 @@ def test_get_sends_get(self):
         result = vpc.get(client, vpc_id)
 
         client.get.assert_called_once_with(
-            f"v1/{PROJECT_ID}/vpcs/{vpc_id}",
+            f"vpcs/{vpc_id}",
         )
         assert result.id == vpc_id
         assert result.cidr == "192.168.0.0/16"
@@ -141,7 +141,7 @@ def test_list_with_opts(self):
         list(vpc.list(client, opts))
 
         call_url = client.get.call_args[0][0]
-        assert f"v1/{PROJECT_ID}/vpcs" in call_url
+        assert f"vpcs" in call_url
 
     def test_list_pagination(self):
         """List follows marker pagination across two pages."""
@@ -195,7 +195,7 @@ def test_update_sends_put(self):
         result = vpc.update(client, vpc_id, opts)
 
         client.put.assert_called_once_with(
-            f"v1/{PROJECT_ID}/vpcs/{vpc_id}",
+            f"vpcs/{vpc_id}",
             json={"vpc": {"name": "vpc1", "description": "test1"}},
         )
         assert result.name == "vpc1"
@@ -233,7 +233,7 @@ def test_delete_sends_delete(self):
         vpc.delete(client, vpc_id)
 
         client.delete.assert_called_once_with(
-            f"v1/{PROJECT_ID}/vpcs/{vpc_id}",
+            f"vpcs/{vpc_id}",
         )
 
     def test_delete_returns_none(self):