fix(configuration): do not validate OTEL_CONFIG_FILE value before using it for file config (open-telemetry#6643)

Author: trentm

experimental/CHANGELOG.md

@@ -10,8 +10,12 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 
 ### :rocket: Features
 
+* feat(configuration): auto-generate TypeScript types from OTel declarative config JSON schema (stable v1.0.0) using `json-schema-to-typescript` and `ajv` [#6533](https://github.com/open-telemetry/opentelemetry-js/pull/6533) @MikeGoldsmith
+
 ### :bug: Bug Fixes
 
+* fix(configuration): do not validate `OTEL_CONFIG_FILE` value before using it for file config [#6643](https://github.com/open-telemetry/opentelemetry-js/pull/6643) @trentm
+
 ### :books: Documentation
 
 ### :house: Internal
@@ -48,7 +52,6 @@ For notes on migrating to 2.x / 0.200.x see [the upgrade guide](doc/upgrade-to-2
 
 ### :rocket: Features
 
-* feat(configuration): auto-generate TypeScript types from OTel declarative config JSON schema (stable v1.0.0) using `json-schema-to-typescript` and `ajv` [#6533](https://github.com/open-telemetry/opentelemetry-js/pull/6533)
 * feat(otlp-transformer): add custom protobuf logs serializer [#6228](https://github.com/open-telemetry/opentelemetry-js/pull/6228) @pichlermarc
 * feat(otlp-transformer): add custom protobuf logs export response deserializer [#6530](https://github.com/open-telemetry/opentelemetry-js/pull/6530) @pichlermarc
 * feat(sdk-node): add `buildSamplerFromConfig` to construct a sampler from a declarative config model [#6536](https://github.com/open-telemetry/opentelemetry-js/pull/6536) @ravitheja4531-cell

experimental/packages/configuration/src/ConfigFactory.ts

@@ -3,12 +3,14 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import { getStringFromEnv } from '@opentelemetry/core';
 import type { ConfigFactory } from './IConfigFactory';
 import { EnvironmentConfigFactory } from './EnvironmentConfigFactory';
-import { FileConfigFactory, hasValidConfigFile } from './FileConfigFactory';
+import { FileConfigFactory } from './FileConfigFactory';
 
 export function createConfigFactory(): ConfigFactory {
-  if (hasValidConfigFile()) {
+  const configFile = getStringFromEnv('OTEL_CONFIG_FILE');
+  if (configFile) {
     return new FileConfigFactory();
   }
   return new EnvironmentConfigFactory();

experimental/packages/configuration/src/FileConfigFactory.ts

@@ -33,23 +33,6 @@ export class FileConfigFactory implements ConfigFactory {
   }
 }
 
-export function hasValidConfigFile(): boolean {
-  const configFile = getStringFromEnv('OTEL_CONFIG_FILE');
-  if (configFile) {
-    if (
-      !(configFile.endsWith('.yaml') || configFile.endsWith('.yml')) ||
-      !fs.existsSync(configFile)
-    ) {
-      diag.warn(
-        `Config file ${configFile} set on OTEL_CONFIG_FILE is not valid`
-      );
-      return false;
-    }
-    return true;
-  }
-  return false;
-}
-
 export function parseConfigFile(): ConfigurationModel {
   const supportedFileVersionPattern = /^1\.0$/;
   const configFile = getStringFromEnv('OTEL_CONFIG_FILE') || '';

experimental/packages/configuration/test/ConfigFactory.test.ts

@@ -2287,14 +2287,14 @@ describe('ConfigFactory', function () {
       });
     });
 
-    it('should return error from invalid config file', function () {
-      const warnSpy = Sinon.spy(diag, 'warn');
-      process.env.OTEL_CONFIG_FILE = './fixtures/invalid.txt';
-      createConfigFactory();
-      Sinon.assert.calledWith(
-        warnSpy,
-        'Config file ./fixtures/invalid.txt set on OTEL_CONFIG_FILE is not valid'
-      );
+    it('should throw on non-existant config file', function () {
+      process.env.OTEL_CONFIG_FILE = 'test/fixtures/no-such-file.txt';
+      try {
+        createConfigFactory();
+      } catch (err) {
+        assert.ok(err);
+        assert.equal(err.code, 'ENOENT');
+      }
     });
 
     it('should throw from invalid config file format', function () {

experimental/packages/opentelemetry-sdk-node/test/start.test.ts

@@ -213,15 +213,6 @@ describe('startNodeSDK', function () {
     await sdk.shutdown();
   });
 
-  it('should return NOOP_SDK when disabled is true', async () => {
-    process.env.OTEL_CONFIG_FILE = 'test/fixtures/kitchen-sink.yaml';
-    const sdk = startNodeSDK({});
-
-    assertDefaultContextManagerRegistered();
-
-    await sdk.shutdown();
-  });
-
   it('should not register a diag logger when OTEL_LOG_LEVEL is not set', async () => {
     delete process.env.OTEL_LOG_LEVEL;
     const spy = Sinon.spy(diag, 'setLogger');