Skip to content

Commit 9726176

Browse files
authored
Add missing dependency to proto_codegen_json.sh (open-telemetry#5236)
* Add missing dependency to proto_codegen_json.sh * Fix README
1 parent 9078b5a commit 9726176

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

opentelemetry-proto-json/README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ Code Generation
2121
---------------
2222

2323
These files were generated automatically using the custom protoc plugin opentelemetry-codegen-json_ from code in opentelemetry-proto_.
24-
To regenerate the code, run ``uv run ./scripts/proto_codegen_json.sh`` from the project root.
24+
To regenerate the code, run ``../scripts/proto_codegen_json.sh``.
2525

2626
To build against a new release or specific commit of opentelemetry-proto_,
2727
update the ``PROTO_REPO_BRANCH_OR_COMMIT`` variable in
28-
``./scripts/proto_codegen_json.sh``. Then run the script and commit the changes
28+
``../scripts/proto_codegen_json.sh``. Then run the script and commit the changes
2929
as well as any fixes needed in the OTLP exporter.
3030

3131
.. _opentelemetry-codegen-json: https://github.com/open-telemetry/opentelemetry-python/tree/main/codegen/opentelemetry-codegen-json

scripts/proto_codegen_json.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ protoc() {
2424
uvx -c $repo_root/gen-requirements.txt \
2525
--python 3.12 \
2626
--from grpcio-tools \
27+
--with "$repo_root/codegen/opentelemetry-codegen-json" \
2728
python -m grpc_tools.protoc "$@"
2829
}
2930

0 commit comments

Comments
 (0)