Adds min_childkey_take to hyperparams v3

[thewhaleking]

Description

Adds the hyperparam min_childkey_take to the Hyperparams v3 runtime call

Related Issue(s)

N/A

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

N/A

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

LOW scrutiny: established write-permission contributor with substantial history; branch feat/thewhaleking/add-min_childkey_take-hyperparams-v3 -> devnet-ready; no trusted Gittensor allowlist match found.

Reviewed the full prefetched diff. The PR only adds min_childkey_take to the existing Hyperparams V3 reporting list and updates the corresponding tests. No .github/, dependency, build-script, origin-check, arithmetic, panic-prone, or storage-mutation changes were introduced.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability found in this additive reporting-only change.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN; established write-permission contributor with substantial opentensor/subtensor history, so review focused on correctness and duplicate-work resolution.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

The change is a narrow additive Hyperparams V3 update: it exposes min_childkey_take through get_effective_min_childkey_take(netuid) and updates the existing name/value tests. No new storage, extrinsic, migration, origin path, weight, dependency, or arithmetic surface is introduced.

Duplicate-work check: #2734 overlaps and adds the same effective value under min_childkey_take_per_subnet; this PR is the better candidate because it uses the externally requested min_childkey_take API name and tests the effective max(global, per-subnet) behavior. #2746 and #2638 overlap the same files but are unrelated by scope.

Auto-fix status: no workspace changes made. git diff --check is clean. Local runtime/src/lib.rs and origin/devnet-ready both have spec_version: 419; I could not complete the live devnet comparison because DNS resolution for dev.chain.opentensor.ai failed in this sandbox. I did not run cargo tests because static inspection was sufficient for this reporting-only addition.

Findings

No findings.

Conclusion

Approve. The implementation is additive, consistent with the Hyperparams V3 dynamic-entry model, and has focused test coverage for both the new name and effective value semantics.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[thewhaleking]

Regarding the failed tests: they are unrelated to this PR, as they also fail in devnet-ready

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍