[primer] rename Router/REED to Active/Standby Mesh Extender#200
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to replace the terms 'Router' and 'REED' (Router Eligible End Device) with 'Active Mesh Extender' and 'Standby Mesh Extender' respectively. The review feedback focuses on ensuring terminology consistency across the modified files, correcting a grammatical tense mismatch, and fixing capitalization inconsistencies for 'End Device'.
| <div>This could be true. If the number of Active Mesh Extenders increases to 24 | ||
| or more, existing Active Mesh Extenders can start evaluating whether to become an | ||
| end device. | ||
| </div> |
There was a problem hiding this comment.
The term 'End Device' is capitalized throughout the rest of the primer. It should be capitalized here as well for consistency.
| <div>This could be true. If the number of Active Mesh Extenders increases to 24 | |
| or more, existing Active Mesh Extenders can start evaluating whether to become an | |
| end device. | |
| </div> | |
| <div>This could be true. If the number of Active Mesh Extenders increases to 24 | |
| or more, existing Active Mesh Extenders can start evaluating whether to become an | |
| End Device. | |
| </div> |
There was a problem hiding this comment.
maybe tackle that in a separate PR: there are numerous instances across multiple docs.
| 1. In return, any Routers or Router Eligible End Devices (REEDs) in range | ||
| broadcast a Beacon that contains their Thread network PAN ID, XPAN ID, and | ||
| Network Name. | ||
| 1. In return, any Mesh Extenders in range broadcast a Beacon that contains |
There was a problem hiding this comment.
Just as a side remark: the use of "Beacon" specifically as 802.15.4 beacon (request) seems incorrect -> was replaced by MLE discovery.
EskoDijk
left a comment
There was a problem hiding this comment.
Overall I agree with the term changes and keeping "RLOC".
Comments are about specific improvements suggested, or issues found.
In general, images still mention REED and Router.
9f1198d to
6cd24db
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to replace legacy terminology, transitioning 'Router' to 'Active Mesh Extender' and 'REED' to 'Standby Mesh Extender' across several guide files. The review feedback is highly constructive, pointing out a technical inversion in the network discovery documentation where 'Child' was used instead of 'Parent', along with several grammatical corrections to ensure proper pronoun agreement and the correct use of indefinite articles with the new terms.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to replace outdated terminology, specifically changing 'Router' to 'Active Mesh Extender' and 'REED' to 'Standby Mesh Extender'. The review feedback is highly constructive, pointing out opportunities to improve terminology consistency (such as replacing 'Parent' with 'Active Mesh Extender' or 'Mesh Extender' in specific contexts) and correcting minor grammatical and pronoun agreement issues introduced by the changes.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to reflect new terminology, replacing terms like 'Router' and 'REED' with 'Active Mesh Extender' and 'Standby Mesh Extender'. The review feedback focuses on improving grammatical agreement, ensuring technical accuracy regarding routing behaviors, maintaining terminology consistency, and correcting minor capitalization issues.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to replace legacy terminology such as "Router" and "REED" with "Active Mesh Extender" and "Standby Mesh Extender". A markup issue was identified in a multiple-choice question component in network-discovery.md where two options were incorrectly grouped into a single block, which would break rendering.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to align with updated terminology, replacing "Router" with "Active Mesh Extender" and "REED" with "Standby Mesh Extender" across several guides. The feedback suggests a minor grammatical improvement to the description of Mesh Extender roles to enhance readability.
Update the Thread Primer documentation to transition terminology from Router and Router Eligible End Device (REED) to Active Mesh Extender and Standby Mesh Extender, respectively. - Rename "Router" to "Active Mesh Extender" (or "Mesh Extender" where referring generally to the device capability). - Rename REED (Router Eligible End Device) to Standby Mesh Extender. - Rename "Router-Router links" to "Active Mesh Extender links". - Adjust roles, device types, addressing, and MLE attach descriptions to use the new terminology. - Fix grammatical errors (e.g., "a Active" to "an Active") and typos introduced during the transition.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Thread primer documentation to align with new terminology, replacing terms like 'Router' and 'REED' with 'Active Mesh Extender' and 'Standby Mesh Extender' across multiple guides. The reviewer provided constructive feedback to further refine these terminology updates for technical accuracy and consistency, such as using 'Active Mesh Extender' instead of 'Parent' in topology descriptions, ensuring scan mask conditions match reference tables, and clarifying that commissioning services are specific to Active Mesh Extenders.
EskoDijk
left a comment
There was a problem hiding this comment.
There are a couple of ot-primer-* figures (PNG) that still use the Router/REED terminology. My guess here is that we want to address all of these, in this PR, so that it covers the entire primer? If so: still to be converted.
(If not: maybe discuss why not)
|
Update: terminology was discussed in call 2026-07-01; leading to a new proposal (SPEC-1288). |
Update the Thread Primer documentation to transition terminology from Router and Router Eligible End Device (REED) to Active Mesh Extender and Standby Mesh Extender, respectively.