Skip to content

Commit 0223b20

Browse files
authored
fix: code check (#293)
1 parent 7bd9c6e commit 0223b20

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

base/src/main/java/com/tinyengine/it/dynamic/service/DynamicModelService.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
import com.alibaba.fastjson.JSON;
44
import com.alibaba.fastjson.JSONArray;
55
import com.tinyengine.it.common.context.LoginUserContext;
6+
import com.tinyengine.it.common.exception.ExceptionEnum;
7+
import com.tinyengine.it.common.exception.ServiceException;
68
import com.tinyengine.it.dynamic.dto.DynamicDelete;
79
import com.tinyengine.it.dynamic.dto.DynamicInsert;
810
import com.tinyengine.it.dynamic.dto.DynamicQuery;
@@ -53,6 +55,8 @@ public void createDynamicTable(Model modelMetadata) {
5355

5456
} catch (Exception e) {
5557
log.error("createDynamicTable failed: {}", tableName, e);
58+
throw new ServiceException(ExceptionEnum.CM001.getResultCode(), ExceptionEnum.CM001.getResultCode());
59+
5660
}
5761
}
5862
private String generateDropTableSQL(String tableName) {
@@ -81,6 +85,8 @@ public void dropDynamicTable(Model modelMetadata) {
8185
log.info("Successfully dropped table: {}", tableName);
8286
} catch (Exception e) {
8387
log.error("Failed to drop table: {}", tableName, e);
88+
throw new ServiceException(ExceptionEnum.CM001.getResultCode(), ExceptionEnum.CM001.getResultCode());
89+
8490
}
8591
}
8692
/**

base/src/main/java/com/tinyengine/it/dynamic/service/DynamicService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ public void validateTableExists(String tableName) {
224224
}
225225
}
226226
private String getTableName(String modelId) {
227-
return "dynamic_" + modelId.toLowerCase();
227+
return "dynamic_" + modelId.toLowerCase(Locale.ROOT);
228228
}
229229

230230

base/src/main/java/com/tinyengine/it/login/config/SSOInterceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public boolean preHandle(HttpServletRequest request,
115115
} catch (Exception e) {
116116
log.error("Token validation exception: {}", e.getMessage(), e);
117117
DefaultLoginUserContext.clear();
118-
throw new Exception(e.getMessage());
118+
throw new ServiceException(ExceptionEnum.CM336.getResultCode(), ExceptionEnum.CM336.getResultMsg());
119119
}
120120
}
121121

base/src/main/java/com/tinyengine/it/service/material/impl/ModelServiceImpl.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,9 @@ public Model deleteModelById(Integer id) {
152152
try {
153153
dynamicModelService.dropDynamicTable(model);
154154
} catch (Exception e) {
155-
log.error("刪除动态表失败", e);
156-
throw new RuntimeException("刪除动态表失败: " + e.getMessage());
155+
log.error("deleteModelById", e);
156+
throw new ServiceException(ExceptionEnum.CM001.getResultCode(), ExceptionEnum.CM001.getResultCode());
157+
157158
}
158159
return model;
159160
}
@@ -188,8 +189,8 @@ public Model updateModelById(Model model) {
188189
try {
189190
dynamicModelService.modifyTableStructure(model);
190191
} catch (Exception e) {
191-
log.error("修改动态表失败", e);
192-
throw new RuntimeException("修改动态表失败: " + e.getMessage());
192+
log.error("updateModelById", e);
193+
throw new ServiceException(ExceptionEnum.CM001.getResultCode(), ExceptionEnum.CM001.getResultCode());
193194
}
194195
Model modelResult = this.baseMapper.selectById(model.getId());
195196
return modelResult;

0 commit comments

Comments
 (0)