Skip to content

Commit 36730b1

Browse files
authored
fix: resolve code check issues (#308)
1 parent b8b6258 commit 36730b1

4 files changed

Lines changed: 17 additions & 7 deletions

File tree

base/src/main/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040
import java.util.Arrays;
4141
import java.util.HashMap;
4242
import java.util.List;
43+
import java.util.Locale;
4344
import java.util.Map;
4445
import java.util.Set;
4546

@@ -265,7 +266,7 @@ void validateFinalUrl(String finalUrl) {
265266
throw new ServiceException("400", "Invalid baseUrl: missing host");
266267
}
267268

268-
boolean isLoopback = LOOPBACK_HOSTS.contains(host.toLowerCase());
269+
boolean isLoopback = LOOPBACK_HOSTS.contains(host.toLowerCase(Locale.ROOT));
269270

270271
List<String> allowedHosts = config.getAllowedHosts();
271272

base/src/test/java/com/tinyengine/it/common/utils/SqlIdentifierValidatorTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
import java.util.Arrays;
66
import java.util.List;
77

8-
import static org.junit.jupiter.api.Assertions.*;
8+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
9+
import static org.junit.jupiter.api.Assertions.assertThrows;
910

1011
class SqlIdentifierValidatorTest {
1112

@@ -101,7 +102,7 @@ void rejectSqliPatternsInIdentifier() {
101102
"name AND 1=1",
102103
"id; SELECT SLEEP(5)",
103104
"COUNT(*)",
104-
"GROUP_CONCAT(username)",
105+
"GROUP_CONCAT(username)"
105106
};
106107
for (String payload : sqliPayloads) {
107108
assertThrows(IllegalArgumentException.class,

base/src/test/java/com/tinyengine/it/dynamic/service/DynamicServiceSqlInjectionTest.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,15 @@
1515
import org.mockito.Mock;
1616
import org.mockito.MockitoAnnotations;
1717

18-
import java.util.*;
19-
20-
import static org.junit.jupiter.api.Assertions.*;
18+
import java.util.ArrayList;
19+
import java.util.Arrays;
20+
import java.util.Collections;
21+
import java.util.HashMap;
22+
import java.util.List;
23+
import java.util.Map;
24+
25+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
26+
import static org.junit.jupiter.api.Assertions.assertThrows;
2127
import static org.mockito.ArgumentMatchers.any;
2228
import static org.mockito.Mockito.when;
2329

base/src/test/java/com/tinyengine/it/service/app/impl/v1/AiChatV1ServiceImplTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@
1313
import java.util.List;
1414
import java.util.Map;
1515

16-
import static org.junit.jupiter.api.Assertions.*;
16+
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
17+
import static org.junit.jupiter.api.Assertions.assertEquals;
18+
import static org.junit.jupiter.api.Assertions.assertThrows;
1719

1820
class AiChatV1ServiceImplTest {
1921
private TestAiChatV1ServiceImpl service;

0 commit comments

Comments
 (0)