Skip to content

Commit 12a25c8

Browse files
committed
fix: resolve review comments
1 parent 22b180c commit 12a25c8

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

packages/common/js/preview.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,6 @@ const { deepClone } = utils
3030
// 保存预览窗口引用
3131
let previewWindow = null
3232

33-
// 创建 BroadcastChannel 实例用于通信
34-
const previewChannel = new BroadcastChannel('tiny-engine-preview-channel')
35-
3633
const getScriptAndStyleDeps = () => {
3734
const { scripts, styles } = useMaterial().getCanvasDeps()
3835
const utilsDeps = useResource().getUtilsDeps()
@@ -184,11 +181,16 @@ const setupMessageListener = () => {
184181
}
185182
})
186183

184+
// 创建 BroadcastChannel 实例用于通信
185+
const previewChannel = new BroadcastChannel('tiny-engine-preview-channel')
186+
187187
// 可能是刷新,需要重新建立连接
188188
previewChannel.postMessage({
189189
event: 'connect',
190190
source: 'designer'
191191
})
192+
193+
previewChannel.close()
192194
}
193195

194196
// 初始化消息监听

packages/design-core/src/preview/src/preview/usePreviewData.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ const getPageAncestryFiles = (
186186
) => {
187187
const familyPages: IPanelType[] = []
188188
const ancestors = params.ancestors
189-
// @ts-ignore
190189
const { generatePageCode } = getMetaApi('engine.service.generateCode')
191190

192191
// 区块预览,没有祖先
@@ -341,7 +340,6 @@ export const usePreviewData = ({ setFiles, store }: IUsePreviewData) => {
341340
const blockSet = new Set()
342341

343342
let blocks = []
344-
// @ts-ignore
345343
const { getAllNestedBlocksSchema, generatePageCode } = getMetaApi('engine.service.generateCode')
346344

347345
if (params.ancestors?.length) {
@@ -371,7 +369,7 @@ export const usePreviewData = ({ setFiles, store }: IUsePreviewData) => {
371369

372370
const newFiles = store.getFiles()
373371
const searchParams = new URLSearchParams(location.search)
374-
const appJsCode = processAppJsCode(newFiles['app.js'], JSON.parse(searchParams.get('styles') || '{}'))
372+
const appJsCode = processAppJsCode(newFiles['app.js'], JSON.parse(searchParams.get('styles') || '[]'))
375373

376374
newFiles['app.js'] = appJsCode
377375

0 commit comments

Comments
 (0)