Skip to content

Commit 5684411

Browse files
authored
feat: remove code to base64 for performance issue (#1328)
1 parent 030ece7 commit 5684411

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

packages/canvas/init-canvas/init-canvas.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,12 @@ export function initCanvas(importMap = {}, importStyleUrls = []) {
99
'<!--%IMPORT_STYLE%-->',
1010
importStyleUrls.map((styleUrl) => `<link rel="stylesheet" crossorigin="" href="${styleUrl}">`).join('\n')
1111
)
12-
.replace('<!--%MAIN_SCRIPT%-->', `<script type="module" src="${canvasScript}"></script>`)
12+
.replace('<!--%MAIN_SCRIPT%-->', () => {
13+
if (import.meta.env.MODE === 'development') {
14+
return `<script type="module" src="${canvasScript}"></script>`
15+
}
16+
17+
return `<script type="module">${canvasScript}</script>`
18+
})
1319
}
1420
}

packages/canvas/scripts/vite-plugin-separate-build.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const queryRE = /[?#].*$/
55

66
const bundleCache = new WeakMap()
77

8-
function cleanUrl(url) {
8+
function cleanUrl(url: string) {
99
return url.replace(queryRE, '')
1010
}
1111
function saveEmitBundleAssets(config, asset) {
@@ -88,10 +88,8 @@ export async function vitePluginBuildEntry(customBuildConfig) {
8888
buildConfig: match.groups.name,
8989
entries: [file]
9090
})
91-
const formatBase64 = (code) => {
92-
return 'data:text/javascript;base64,' + Buffer.from(code).toString('base64')
93-
}
94-
return `export default ${JSON.stringify(formatBase64(code))}\n`
91+
92+
return `export default ${JSON.stringify(code)}`
9593
},
9694
generateBundle(opts, bundle) {
9795
if (opts.__vite_skip_assets_emit__) {

0 commit comments

Comments
 (0)