fix(layout): normalize URL pathname and construction#1788
Closed
chilingling wants to merge 1 commit intoopentiny:developfrom
Closed
fix(layout): normalize URL pathname and construction#1788chilingling wants to merge 1 commit intoopentiny:developfrom
chilingling wants to merge 1 commit intoopentiny:developfrom
Conversation
Contributor
WalkthroughReplaced ad-hoc URL string manipulation with deriving Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b144b50 to
5265800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
【问题描述】What is the current behavior?
当前如果没有正确的应用 id,会自动跳转到应用中心。
如果用户输入随机的路经,然后在应用中心中跳转应用,新增的 path 不会消失。
比如:
https://opentiny.github.io/tiny-engine/xxxx,由于没有正确的应用id,会默认跳转到应用中心。xxxx却没有消失。跟随带入了应用的 path。Issue Number: N/A
【优化方案】What is the new behavior?
构建验证地址:https://chilingling.github.io/tiny-engine/?type=app&id=1&tenant=1
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit