Skip to content

fix(file-upload): Uploading the component name "group" causes it to become invalid.#4193

Open
discreted66 wants to merge 1 commit intoopentiny:devfrom
discreted66:lk0424
Open

fix(file-upload): Uploading the component name "group" causes it to become invalid.#4193
discreted66 wants to merge 1 commit intoopentiny:devfrom
discreted66:lk0424

Conversation

@discreted66
Copy link
Copy Markdown
Collaborator

@discreted66 discreted66 commented Apr 24, 2026

PR

fix:上传组件名group失效 发 81

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Fixed hover interactions on the upload list component to ensure UI controls respond correctly to user interactions.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 24, 2026

Walkthrough

A Tailwind CSS utility class in a Vue upload list component is updated from an unscoped group to a named group/upload-list. This aligns the parent wrapper's group identifier with the group-hover/upload-list variants referenced by child controls.

Changes

Cohort / File(s) Summary
Tailwind Group Naming
packages/vue/src/upload-list/src/mobile-first.vue
Updated the group utility class from group to group/upload-list to ensure hover selectors on child elements properly target the renamed parent group.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A group was renamed with care,
From plain to /upload-list with flair,
Now hover effects align just right,
Child controls glow with delight,
Tailwind magic, pure and fair!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title claims the component name 'group' becomes invalid when uploading, but the actual change renames the Tailwind 'group' utility class to 'group/upload-list' to fix selector behavior, which is different from the stated problem. Update the title to accurately describe the change: something like 'fix(file-upload): Use named group variant for upload list hover states' or 'fix(file-upload): Rename group to group/upload-list for proper hover behavior'.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the bug Something isn't working label Apr 24, 2026
@discreted66 discreted66 reopened this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant