feat(transit-vehicle-overlay): Add optional per-vehicle color#458
Open
mcleinman wants to merge 1 commit into
Open
feat(transit-vehicle-overlay): Add optional per-vehicle color#458mcleinman wants to merge 1 commit into
mcleinman wants to merge 1 commit into
Conversation
Collaborator
Hi @mcleinman, thanks for this PR. By curiosity, could you provide a clarification of what the highlight color on one vehicle, but not others on the same transit route, is intended to mean? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow optional per-vehicle colors in transit-vehicle-overlay. This is not a breaking change; it will continue to default to the color provided to the entire object if a vehicle does not have a valid color. I also updated one of the stories to show this new functionality.
This is similar to #442. We're likely going to update to a non-raster-tiles version, so we need this functionality in the main branch as well.