Basic infrastructure to prepare for strict mode updates#941
Open
daniel-heppner-ibigroup wants to merge 7 commits into
Open
Basic infrastructure to prepare for strict mode updates#941daniel-heppner-ibigroup wants to merge 7 commits into
daniel-heppner-ibigroup wants to merge 7 commits into
Conversation
miles-grant-ibigroup
approved these changes
May 4, 2026
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Unhoisted! Wow we are so on the ground
| Star, | ||
| Train, | ||
| } from "styled-icons/fa-solid"; | ||
| } from "@styled-icons/fa-solid"; |
Collaborator
There was a problem hiding this comment.
How did this ever work lol
| "react-map-gl": "catalog:" | ||
| }, | ||
| "gitHead": "0af1b7cda60bd4252b219dcf893e01c2acb2ed5d" | ||
| "gitHead": "0af1b7cda60bd4252b219dcf893e01c2acb2ed5d", |
Collaborator
There was a problem hiding this comment.
What is this even for
Contributor
Author
There was a problem hiding this comment.
apparently this is something lerna uses... idk if we need it but I'm just going to leave it for now
miles-grant-ibigroup
assigned
daniel-heppner-ibigroup and unassigned
miles-grant-ibigroup
…e deps - Set TS compile target to es2020 - Remove dep hoisting, add pnpm-workspace.yaml config - Add missing type dependencies to packages without strict-mode branches - Fix husky setup
daniel-heppner-ibigroup
force-pushed
the
strict-mode-tooling
branch
from
3764eff to
3c97830
Compare
alec-georgoff
approved these changes
May 7, 2026
daniel-heppner-ibigroup
added
the
BLOCKERS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mostly focused on removing hoisted modules, which surfaced a bunch of dependencies that were missing in packages around the app. I went through and added those dependencies to the specific packages where they're required.
This was a necessary precursor to enabling strict mode since we need to more tightly control the dependencies of each package to get the types correct.