UCT/CUDA/CUDA_IPC: Separated get and put remote cache methods.#11501
Open
rakhmets wants to merge 1 commit into
Open
UCT/CUDA/CUDA_IPC: Separated get and put remote cache methods.#11501rakhmets wants to merge 1 commit into
rakhmets wants to merge 1 commit into
Conversation
rakhmets
force-pushed
the
topic/cuda-ipc-get-remote-cache
branch
from
8f6c42e to
3870eee
Compare
Contributor
Author
|
🤖 Starting review — findings will be posted here when done. |
svc-nvidia-pr-review
left a comment
svc-nvidia-pr-review
left a comment
There was a problem hiding this comment.
Code Review
2 findings — 🚨 2 blockers
2 findings posted as inline comments.
rakhmets
force-pushed
the
topic/cuda-ipc-get-remote-cache
branch
from
45caec2 to
17616e4
Compare
Contributor
Author
|
🤖 Starting review — findings will be posted here when done. |
svc-nvidia-pr-review
left a comment
svc-nvidia-pr-review
left a comment
There was a problem hiding this comment.
Code Review
No issues found. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Separated
uct_cuda_ipc_get_remote_cacheinto get and put parts. To useuct_cuda_ipc_put_remote_cacheinuct_cuda_ipc_map_memhandle, anduct_cuda_ipc_get_remote_cacheinuct_cuda_ipc_unmap_memhandle.