UCT/IB: Propagate traffic class in address for symmetric QoS#11309
Open
ndg8743 wants to merge 2 commits into
Open
UCT/IB: Propagate traffic class in address for symmetric QoS#11309ndg8743 wants to merge 2 commits into
ndg8743 wants to merge 2 commits into
Conversation
Pack the traffic class into the IB address exchanged during connection setup so the remote side can apply it when the local interface has no traffic class configured. This fixes one-directional DSCP/TC when UCX_IB_TRAFFIC_CLASS is set, ensuring both sides of an RC connection use the same traffic class value. Also update the DevX QP connect path to read traffic class from ah_attr (which may carry the remote value) instead of always using the local iface config. Closes openucx#10325
ndg8743
force-pushed
the
fix/symmetric-traffic-class
branch
from
20b1e67 to
0c982d8
Compare
Author
|
CI failures are infrastructure flakes on RoCE worker 3 (mlx5_1 device degraded), unrelated to traffic class changes:
All failures trace back to mlx5_1 UMR CQ timeouts on the same worker node. Retriggering CI. |
ndg8743
force-pushed
the
fix/symmetric-traffic-class
branch
from
d68a22e to
0c982d8
Compare
The UCT_IB_ADDRESS_FLAG_TRAFFIC_CLASS at BIT(7) overlaps with the RoCE version bits in the flags byte. The version extraction does flags >> 5, which includes bit 7, corrupting the RoCE version when traffic class is packed. Mask out the traffic class flag before extracting the version. Also initialize traffic_class in test pack_params to avoid reading uninitialized memory when the traffic class flag is set.
ndg8743
force-pushed
the
fix/symmetric-traffic-class
branch
from
0c982d8 to
8962d27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ah_attr->grh.traffic_classinstead of always reading from local iface configFixes #10325