Fix compilation when using without-gda#11615
Open
ofirfarjun7 wants to merge 8 commits into
Open
Conversation
tvegas1
previously approved these changes
Jul 2, 2026
rakhmets
reviewed
Jul 2, 2026
Comment on lines
+15
to
+16
| #if defined(HAVE_CONFIG_H) && defined(HAVE_CUDA) && \ | ||
| __has_include(<uct/cuda/cuda_ipc/cuda_ipc.cuh>) |
Contributor
There was a problem hiding this comment.
I am not sure if it will work with 3rd party code.
These defines are set inside UCX build infrastructure. However, the 3rd party code that includes UCX headers will miss the defines.
I think the issue might be fixed using the same directive (__has_include) in gdaki.cuh.
Contributor
There was a problem hiding this comment.
can't we basing on presence of cuda_ipc.cuh assume that build/package checked all dependencies?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix for #11591